585208 - reference to undefined Object.getOwnProperties

Status: RESOLVED FIXED

(Other Applications Graveyard :: Narcissus, defect)

Description

[Dave Herman [:dherman]]

The proxy handler created in jsexec.newFunction makes reference to Object.getOwnProperties, which is not defined. The origin of that code:

    http://wiki.ecmascript.org/doku.php?id=harmony:proxies

expects an implementation like this:

    http://code.google.com/p/es-lab/source/browse/trunk/src/traits/traits.js

This needs to be defined somewhere in Narcissus if it's going to be used.

Dave

Comment 1

[Dave Herman [:dherman]]

Also, the |enumerateOwn| trap should be called keys.

Dave

Comment 2

[Dave Herman [:dherman]]

Attachment: implements getOwnProperties, plus a little cleanup

Comment 3

[Dave Herman [:dherman]]

Oh, Object.getPropertyDescriptor also doesn't exist. But it's pretty easy to implement. Updating the patch in a sec.

Dave

Comment 4

[Dave Herman [:dherman]]

Attachment: implements getOwnProperties and getPropertyDescriptor, plus a little cleanup

Updated to implement getPropertyDescriptor as well.

Dave

Comment 5

[Dave Herman [:dherman]]

http://hg.mozilla.org/tracemonkey/rev/8c22931336c5