If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

reference to undefined Object.getOwnProperties

RESOLVED FIXED

Status

Other Applications
Narcissus
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dherman, Assigned: dherman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
The proxy handler created in jsexec.newFunction makes reference to Object.getOwnProperties, which is not defined. The origin of that code:

    http://wiki.ecmascript.org/doku.php?id=harmony:proxies

expects an implementation like this:

    http://code.google.com/p/es-lab/source/browse/trunk/src/traits/traits.js

This needs to be defined somewhere in Narcissus if it's going to be used.

Dave
(Assignee)

Comment 1

7 years ago
Also, the |enumerateOwn| trap should be called keys.

Dave
(Assignee)

Comment 2

7 years ago
Created attachment 463720 [details] [diff] [review]
implements getOwnProperties, plus a little cleanup
Assignee: nobody → dherman
Attachment #463720 - Flags: review?(taustin)
(Assignee)

Comment 3

7 years ago
Oh, Object.getPropertyDescriptor also doesn't exist. But it's pretty easy to implement. Updating the patch in a sec.

Dave
(Assignee)

Comment 4

7 years ago
Created attachment 463722 [details] [diff] [review]
implements getOwnProperties and getPropertyDescriptor, plus a little cleanup

Updated to implement getPropertyDescriptor as well.

Dave
Attachment #463720 - Attachment is obsolete: true
Attachment #463722 - Flags: review?(taustin)
Attachment #463720 - Flags: review?(taustin)

Updated

7 years ago
Attachment #463722 - Flags: review?(taustin) → review+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/tracemonkey/rev/8c22931336c5
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.