585228 - Cleanup the window scriptable helper some

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Now that the inner and outer windows don't share a scriptable helper, we can move some work out of the inner window.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: NewEnumerate can move the outer

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: innerObject and outerObject should be on the outer SH and inner SH respectively

After this patch, we can actually make some code that calls the innerObject hook just check for its presence, which might save some perf in eval.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: newResolve and addProperty

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 463716 [details] [diff] [review]
innerObject and outerObject should be on the outer SH and inner SH respectively

- In nsOuterWindowSH::InnerObject():

     nsGlobalWindow *inner = win->GetCurrentInnerWindowInternal();
     if (!inner) {
       // Yikes! No inner window! Instead of leaking the outer window into the
       // scope chain, let's return an error.
+      // XXX Can this still happen?

Maybe assert that it is so?

r=jst

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/36c4d4e837bb
http://hg.mozilla.org/tracemonkey/rev/ce00848a1ed6
http://hg.mozilla.org/tracemonkey/rev/556eca04e304

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/36c4d4e837bb