585298 - Syntax Highlighting feature in View Page Source window does not react instantaneously

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Kamil Lach]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100804 Minefield/4.0b3pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100804 Minefield/4.0b3pre

Syntax Highlighting feature in View Page Source window does not react instantaneously to the actions undertaken by the user ie. turning on/turning off syntax highlighting. To see the changes (coloured or discoloured syntax in the code) it is necessary to close the view page source window and open it again. 
The "wrap long lines" functionality works ok and instantaneously though.

The issue was noticed in builds with both en-gb and pl locale.

Reproducible: Always

Steps to Reproduce:
1.Navigate to a website of your own choice.
2.Open the View Page Source window (by mouse or keyboard shortcut).
3.In the View menu item check/uncheck the Syntax Highlighting option.
Actual Results:  
The source code of the page remains in the initial state as when the view source window was opened instead of immediately react to the user's actions and turn the syntax highlighting feature on or off. The menu item gets correctly checked/unchecked but it does not affect the code itself.

Expected Results:  
The source code should have the syntax highlighting feature enabled/disabled on the fly as user selects the appropriate option in the menu.

Comment 1

[Hubert Gajewski]

I can confirm.

Comment 2

[Boris Zbarsky [:bzbarsky]]

This used to work.  Who broke it?

Comment 3

[Boris Zbarsky [:bzbarsky]]

In particular, this has regressed since 3.6.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f57b95afb57e&tochange=f557921b88a7

Comment 5

[Boris Zbarsky [:bzbarsky]]

This is the same underlying issue as bug 582795: loadPage got broken.

Comment 6

[Rob Campbell [:rc] (:robcee)]

view source has its own component, moving there.

Comment 7

[j.j.]

Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101125 Firefox/4.0b8pre

Fixed with bug 582795