Last Comment Bug 585308 - change access key for account settings to S to match main pane
: change access key for account settings to S to match main pane
Status: VERIFIED FIXED
: ux-consistency
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: Trunk
: x86 Windows Vista
: -- trivial (vote)
: Thunderbird 11.0
Assigned To: :aceman
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-07 07:00 PDT by Wayne Mery (:wsmwk, NI for questions)
Modified: 2011-11-21 06:57 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch for Windows (1.05 KB, patch)
2011-11-11 16:45 PST, :aceman
mozilla: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Wayne Mery (:wsmwk, NI for questions) 2010-08-07 07:00:13 PDT
main 3pane - Tools, S is the shortcut for Account settings
compose - Tools, C is the shortcut for Account settings

Please alter to S in the compose pane so the keys match main pane
Comment 1 :aceman 2011-11-11 16:28:05 PST
Does this depend on the platform?
I have these on linux:
main 3pane - Edit, A is the shortcut for Account settings (S is taken by Select)
compose - Edit, S is the shortcut for Account settings (A is taken by Select All)
Comment 2 :aceman 2011-11-11 16:45:54 PST
Created attachment 573961 [details] [diff] [review]
patch for Windows

If you can test the patch (I can't build for Win), make sure there are no collisions. On Linux, S isn't yet taken in Tools.
Comment 3 Blake Winton (:bwinton) (:☕️) 2011-11-15 08:58:42 PST
Comment on attachment 573961 [details] [diff] [review]
patch for Windows

Review of attachment 573961 [details] [diff] [review]:
-----------------------------------------------------------------

I like it (on Windows, that is.  On Mac, we don't seem to show or use accesskeys).  ui-r=me!

::: mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
@@ -172,1 +172,1 @@
> >  <!ENTITY accountManagerCmdUnix.accesskey "S">

Since these are the same, do we still need them both?
Comment 4 :aceman 2011-11-15 10:36:48 PST
I think we should leave it for safety. As the Account settings are in different menus on Linux and Windows, there are different requirements for the accesskey. It may be needed to split them again in the future.
Comment 5 David :Bienvenu 2011-11-15 17:24:48 PST
Comment on attachment 573961 [details] [diff] [review]
patch for Windows

If Blake's happy with it, it's fine with me, thx for the patch.
Comment 6 Mark Banner (:standard8) 2011-11-17 03:15:29 PST
Checked in: http://hg.mozilla.org/comm-central/rev/9c8c54d9963c

Note You need to log in before you can comment on or make changes to this bug.