The default bug view has changed. See this FAQ.

change access key for account settings to S to match main pane

VERIFIED FIXED in Thunderbird 11.0

Status

Thunderbird
Message Compose Window
--
trivial
VERIFIED FIXED
7 years ago
5 years ago

People

(Reporter: wsmwk, Assigned: aceman)

Tracking

({ux-consistency})

Trunk
Thunderbird 11.0
x86
Windows Vista
ux-consistency

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

main 3pane - Tools, S is the shortcut for Account settings
compose - Tools, C is the shortcut for Account settings

Please alter to S in the compose pane so the keys match main pane
(Assignee)

Comment 1

5 years ago
Does this depend on the platform?
I have these on linux:
main 3pane - Edit, A is the shortcut for Account settings (S is taken by Select)
compose - Edit, S is the shortcut for Account settings (A is taken by Select All)
Keywords: uiwanted, ux-consistency
(Assignee)

Comment 2

5 years ago
Created attachment 573961 [details] [diff] [review]
patch for Windows

If you can test the patch (I can't build for Win), make sure there are no collisions. On Linux, S isn't yet taken in Tools.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #573961 - Flags: ui-review?(bwinton)
Comment on attachment 573961 [details] [diff] [review]
patch for Windows

Review of attachment 573961 [details] [diff] [review]:
-----------------------------------------------------------------

I like it (on Windows, that is.  On Mac, we don't seem to show or use accesskeys).  ui-r=me!

::: mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
@@ -172,1 +172,1 @@
> >  <!ENTITY accountManagerCmdUnix.accesskey "S">

Since these are the same, do we still need them both?
Attachment #573961 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 4

5 years ago
I think we should leave it for safety. As the Account settings are in different menus on Linux and Windows, there are different requirements for the accesskey. It may be needed to split them again in the future.
(Assignee)

Updated

5 years ago
Attachment #573961 - Flags: review?(dbienvenu)

Comment 5

5 years ago
Comment on attachment 573961 [details] [diff] [review]
patch for Windows

If Blake's happy with it, it's fine with me, thx for the patch.
Attachment #573961 - Flags: review?(dbienvenu) → review+
(Assignee)

Updated

5 years ago
Keywords: uiwanted → checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/9c8c54d9963c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
(Assignee)

Updated

5 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.