585357 - DOM Nodes's find behavior should match browser find

Status: RESOLVED INCOMPLETE

(Other Applications :: DOM Inspector, enhancement)

Description

[Colby Russell :crussell (no longer Mozilla-ing)]

Steps to reproduce, supposing you have some nodes which appear in this order:

DIV id="A"
DIV id="B"
DIV id="C"

1. Set the tree's currentIndex to the "B" row (e.g., click on it to make the focus rect appear).
2. Open Find Nodes dialog.
3. Search for a DIV, using search by tag.

Expected results:
The tree will reveal the "C" div.

Actual results:
The tree reveals the "A" div.

Find uses an internally-maintained pointer (via the tree walker it uses). It distinguishes between Find and Find Next by setting the node pointer to the tree's root node (via instantiating a new tree walker) for Find, and relying on the walker's last position for Find Next. Instead, it should only ever start at the root node if:
  a) currentIndex is -1
  b) we reach the end of the document

A consequence of b is that fixing this bug effectively implements wraparound find.

Implementation caveats:
inDeepTreeWalker currently doesn't support setting currentNode <http://mxr.mozilla.org/mozilla/source/layout/inspector/src/inDeepTreeWalker.cpp#168>. When this gets fixed on mozilla-central, we will need a JS workaround for supported legacy platforms, which, upon failure to set currentNode, just loops over undesirable nodes that precede the desired currentNode.

Comment 1

[Firefox Bug Husbandry Bot]

Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023

Comment 2

[Firefox Bug Husbandry Bot]

Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023