585451 - Quickstub of nsIDOMSVGStylable.* breaks build with SVG disabled

Status: RESOLVED WONTFIX

(Core :: SVG, defect)

Description

[Mounir Lamouri (:mounir)]

js/src/xpconnect/src/dom_quickstubs.qsconf now contains reference to nsIDOMSVGStylable thus need the related IDL file and building gecko with SVG disabled do not provide this file in dist/idl which breaks the build.
Unfortunately, pre-processor instructions do not work in dom_quickstubs.qsconf so, I only see two options: do not quickstub nsIDOMSVGStylable or do not let Gecko to be built without SVG support (see bug 585020).

Comment 1

[Boris Zbarsky [:bzbarsky]]

> Unfortunately, pre-processor instructions do not work in dom_quickstubs.qsconf

Can we fix that?

Comment 2

[Robert Longson [:longsonr]]

Simpler just to have the necessary files in dist/idl always build I think. A subset of bug 585020.

Comment 3

[Boris Zbarsky [:bzbarsky]]

dist/idl may not be good enough, since the quickstub code uses nsSVGStylableElement directly.

Comment 4

[Robert Longson [:longsonr]]

Ahh. Someone's picked up bug 585020 so if that lands this will come out in the wash.

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to comment #1)
> > Unfortunately, pre-processor instructions do not work in dom_quickstubs.qsconf
> 
> Can we fix that?

I'm wondering if we could fix that by checking for MOZ_SVG in the Makefile and call qsgen.py with --with-svg/--without-svg which will add a variable (like 'svgEnabled':true) to |config| passed to |execfile(filename, config)|. Then, in dom_quickstubs.qsconf we could add svg related stuff to the arrays only if svgEnabled is true.

Comment 6

[Boris Zbarsky [:bzbarsky]]

That seems plausible, if we decide to keep the build option.

Comment 7

[(not currently active) Ted Mielczarek]

bug 585020 has a patch that I think we'll take, so should we just wontfix this?