585512 - log file created with wonky permissions

Status: RESOLVED FIXED

(Mozilla Labs :: Contacts, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

The log file that the extension creates in the profile directory has wonky permissions:

    ---x--x--T 1 myk myk 0 2010-07-29 14:59 people-log.txt

It looks like the file is being created with permissions set to 600 instead of 0600 (i.e. an octal number, as expected by nsIFile::create).  Here's a patch that fixes that.  I haven't tested it, but I'm pretty sure it's the right fix.

Comment 1

[Michael Hanson]

looks reasonable. sr+

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 463981 [details] [diff] [review]
patch v1: fixes problem

Marking r+ per Mike's comment 1.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Mike: I notice that the default "branch" is inactive, with all recent development taking place on the tb-0.3.5 branch (or the oauth branch, which was recently merged into tb-0.3.5).  Where should I commit this patch?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Via other channels, Mike told me to push to the oauth branch, which is getting regularly merged into the tb-0.3.5 branch (and both of which will eventually merge into the trunk, most likely), so I have done so.

Fixed by changeset http://hg.mozilla.org/labs/people/rev/3749958a1570.