Clean up the v8.5 earley-boyer benchmark

RESOLVED FIXED

Status

Tamarin
Virtual Machine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Lars T Hansen, Assigned: Lars T Hansen)

Tracking

Details

(Whiteboard: has-patch)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 464023 [details] [diff] [review]
Patch for the 'untyped' case only

This benchmark was never enabled (probably because of bug #464134) and needs a little TLC in order to run.

(The v8 benchmark (as opposed to the v8.5) is further away from the mark and I probably won't bother.)
Attachment #464023 - Flags: review?(edwsmith)
(Assignee)

Comment 1

8 years ago
Created attachment 464031 [details] [diff] [review]
Patch for all cases, plus testconfig

Note, there's a new comment in testconfig.txt that I'll need to clean up before this lands by creating a new bug (maybe).
Attachment #464023 - Attachment is obsolete: true
Attachment #464031 - Flags: review?(edwsmith)
Attachment #464023 - Flags: review?(edwsmith)
(Assignee)

Comment 2

8 years ago
The corresponding v8 issue is tracked by bug #585586.
(Assignee)

Updated

8 years ago
Blocks: 571469
(Assignee)

Updated

8 years ago
Whiteboard: has-patch

Comment 3

8 years ago
Comment on attachment 464031 [details] [diff] [review]
Patch for all cases, plus testconfig

testConfig.txt:105 reads "# some tests are beyond rescue  - note, 464134 is NOT the reason"

leaves me wondering what *is* the reason, and should we update the bug#
Attachment #464031 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> testConfig.txt:105 reads "# some tests are beyond rescue  - note, 464134 is NOT
> the reason"
> 
> leaves me wondering what *is* the reason, and should we update the bug#

That would be bug #585586.  The comment disappears as soon as the fixes in that bug land, in any case.
(Assignee)

Comment 5

8 years ago
tamarin-redux changeset:   5000:6f67eed0358e.

Followup cleanup work: bug #585881.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.