585564 - Clean up the v8.5 earley-boyer benchmark

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Lars T Hansen]

Attachment: Patch for the 'untyped' case only

This benchmark was never enabled (probably because of bug #464134) and needs a little TLC in order to run.

(The v8 benchmark (as opposed to the v8.5) is further away from the mark and I probably won't bother.)

Comment 1

[Lars T Hansen]

Attachment: Patch for all cases, plus testconfig

Note, there's a new comment in testconfig.txt that I'll need to clean up before this lands by creating a new bug (maybe).

Comment 2

[Lars T Hansen]

The corresponding v8 issue is tracked by bug #585586.

Comment 3

[Edwin Smith]

Comment on attachment 464031 [details] [diff] [review]
Patch for all cases, plus testconfig

testConfig.txt:105 reads "# some tests are beyond rescue  - note, 464134 is NOT the reason"

leaves me wondering what *is* the reason, and should we update the bug#

Comment 4

[Lars T Hansen]

(In reply to comment #3)
> testConfig.txt:105 reads "# some tests are beyond rescue  - note, 464134 is NOT
> the reason"
> 
> leaves me wondering what *is* the reason, and should we update the bug#

That would be bug #585586.  The comment disappears as soon as the fixes in that bug land, in any case.

Comment 5

[Lars T Hansen]

tamarin-redux changeset:   5000:6f67eed0358e.

Followup cleanup work: bug #585881.