bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Clean up the v8 earley-boyer benchmark

RESOLVED FIXED

Status

Tamarin
Virtual Machine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Lars T Hansen, Assigned: Lars T Hansen)

Tracking

Details

(Whiteboard: has-patch)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
This benchmark was never enabled (probably because of bug #464134) and needs a
fair amount of TLC in order to run.

See bug #585564 for the v8.5 earley-boyer benchmark, which also needed fixing.  The v8 version is probably a little more work to fix.

There is a line in the testconfig.txt that blocks the execution of the v8 earley-boyer benchmark on account of the present bug.
(Assignee)

Comment 1

8 years ago
Created attachment 464035 [details] [diff] [review]
Patch

Not too bad after all.  This patch does not contain changes to testconfig.txt.
Attachment #464035 - Flags: review?(edwsmith)
(Assignee)

Updated

8 years ago
Whiteboard: has-patch

Comment 2

8 years ago
Comment on attachment 464035 [details] [diff] [review]
Patch

Nothing obviously wrong, but curious: where in the old code is the "else" half of this conditional in the new code:

    var reg = (re instanceof RegExp) ? re (re) : sc_pregexp(re);
                                                 ^^^^^^^^^^^^^^^

?
Attachment #464035 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> Comment on attachment 464035 [details] [diff] [review]
> Patch
> 
> Nothing obviously wrong, but curious: where in the old code is the "else" half
> of this conditional in the new code:
> 
>     var reg = (re instanceof RegExp) ? re (re) : sc_pregexp(re);
>                                                  ^^^^^^^^^^^^^^^
> 
> ?

Good point, I'll ponder that.
(Assignee)

Comment 4

8 years ago
tamarin-redux changeset:   5000:6f67eed0358e.

Followup cleanup work: bug #585881.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.