585586 - Clean up the v8 earley-boyer benchmark

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Lars T Hansen]

This benchmark was never enabled (probably because of bug #464134) and needs a
fair amount of TLC in order to run.

See bug #585564 for the v8.5 earley-boyer benchmark, which also needed fixing.  The v8 version is probably a little more work to fix.

There is a line in the testconfig.txt that blocks the execution of the v8 earley-boyer benchmark on account of the present bug.

Comment 1

[Lars T Hansen]

Attachment: Patch

Not too bad after all.  This patch does not contain changes to testconfig.txt.

Comment 2

[Edwin Smith]

Comment on attachment 464035 [details] [diff] [review]
Patch

Nothing obviously wrong, but curious: where in the old code is the "else" half of this conditional in the new code:

    var reg = (re instanceof RegExp) ? re (re) : sc_pregexp(re);
                                                 ^^^^^^^^^^^^^^^

?

Comment 3

[Lars T Hansen]

(In reply to comment #2)
> Comment on attachment 464035 [details] [diff] [review]
> Patch
> 
> Nothing obviously wrong, but curious: where in the old code is the "else" half
> of this conditional in the new code:
> 
>     var reg = (re instanceof RegExp) ? re (re) : sc_pregexp(re);
>                                                  ^^^^^^^^^^^^^^^
> 
> ?

Good point, I'll ponder that.

Comment 4

[Lars T Hansen]

tamarin-redux changeset:   5000:6f67eed0358e.

Followup cleanup work: bug #585881.