585594 - Crash [@Link::UnregisterFromHistory()]

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Unfortunately history is null for this call in Link::UnregistorFromHistory:
history->UnregisterVisitedCallback(mCachedURI, this);

I managed to attach a debugger:

[August 6th FF trunk]

>	xul.dll!mozilla::dom::Link::UnregisterFromHistory()  Line 513 + 0x22 bytes	C++
 	xul.dll!mozilla::dom::Link::ResetLinkState(bool aNotify=false)  Line 484	C++
 	xul.dll!nsHTMLAnchorElement::UnbindFromTree(int aDeep=1, int aNullParent=1)  Line 217	C++
 	xul.dll!nsGenericElement::cycleCollection::Unlink(void * p=0x0c618e60)  Line 4331	C++
 	xul.dll!nsCycleCollector::CollectWhite()  Line 1784 + 0x1a bytes	C++
 	xul.dll!nsCycleCollector::FinishCollection()  Line 2655 + 0x8 bytes	C++
 	xul.dll!nsCycleCollector::Collect(unsigned int aTryCollections=5)  Line 2471 + 0x1a bytes	C++
 	xul.dll!nsCycleCollector::Shutdown()  Line 2708	C++
 	xul.dll!nsCycleCollector_shutdown()  Line 3191	C++
 	xul.dll!mozilla::ShutdownXPCOM(nsIServiceManager * servMgr=0x00000000)  Line 656	C++
 	xul.dll!NS_ShutdownXPCOM_P(nsIServiceManager * servMgr=0x02337de4)  Line 558 + 0x9 bytes	C++
 	xul.dll!ScopedXPCOMStartup::~ScopedXPCOMStartup()  Line 1115 + 0xb bytes	C++
 	xul.dll!XRE_main(int argc=1, char * * argv=0x009bee50, const nsXREAppData * aAppData=0x0231f748)  Line 3708	C++
 	firefox.exe!NS_internal_main(int argc=1, char * * argv=0x009bee50)  Line 158 + 0x12 bytes	C++
 	firefox.exe!wmain(int argc=1, wchar_t * * argv=0x009bf308)  Line 121 + 0xd bytes	C++
 	firefox.exe!__tmainCRTStartup()  Line 583 + 0x19 bytes	C
 	firefox.exe!wmainCRTStartup()  Line 403	C
 	kernel32.dll!76d13677() 	
 	[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]	
 	ntdll.dll!775c9d42() 	
 	ntdll.dll!775c9d15() 	


Recent shell spew:
--DOCSHELL 048AF750 == 1
WARNING: nsExceptionService ignoring thread destruction after shutdown: file c:/Users/davidb/moz/mozilla-central/xpcom/base/nsExce
ptionService.cpp, line 197
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIAnnotationService.removeObserver]"  nsresu
lt: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/PlacesUtils.jsm :: PU_observe :: line 297
"  data: no]
************************************************************
###!!! ASSERTION: Not all Links were removed before we disappear!: 'mObservers.Count() == 0', file c:/Users/davidb/moz/mozilla-cen
tral/toolkit/components/places/src/History.cpp, line 936
nsXPConnect::CommenceShutdown()
WARNING: NS_ENSURE_TRUE(!(mAsyncExecutionThread)) failed: file c:/Users/davidb/moz/mozilla-central/storage/src/mozStorageConnectio
n.cpp, line 627
###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().: 'mRawPtr != 0', file c:\users\davidb\moz\mozilla-centr
al\objdir\dist\include\nsCOMPtr.h, line 819

Comment 1

[Marco Bonardo [:mak]]

I think bug 568969 could have fixed this, since now Link has a strong pointer to History

Comment 2

[Marco Bonardo [:mak]]

ehr, not yet fixed in central

Comment 3

[Marco Bonardo [:mak]]

should have been fixed by the dependency bug 568969.