585628 - Shared builds broken building xpcshell by bug 579178 - manifest enumeration changes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: Possible fix

Bug 579178 broke shared builds:

link -NOLOGO -OUT:xpcshell.exe -PDB:xpcshell.pdb  -NXCOMPAT -DYNAMICBASE -SAFESEH  -DEBUG -DEBUGTYPE:CV  xpcshell.obj ./module.res ../../../../dist/lib/xpcomglue_s.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/xpcom.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/xul.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/mozalloc.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/mozjs.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/nspr4.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/plc4.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/plds4.lib kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib
xpcshell.obj : error LNK2019: unresolved external symbol __imp__XRE_AddManifestLocation referenced in function _main
NEXT ERROR xpcshell.exe : fatal error LNK1120: 1 unresolved externals

Possible fix attached, I'm currently building this, though I am told it has compiled on windows.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

This patch lets me build Thunderbird and run xpcshell tests on OS X 10.6, fwiw.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 464067 [details] [diff] [review]
Possible fix

This should fix the bustage for shared builds.

Comment 3

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/66819a83b0f6