Closed Bug 58571 Opened 24 years ago Closed 23 years ago

javascript strict warnings in SearchDialog.js

Categories

(SeaMonkey :: MailNews: Message Display, defect, P5)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: bugzilla, Assigned: stephend)

References

Details

Attachments

(3 files)

proposed patch
1.82 KB, patch
Details | Diff | Splinter Review
[patch] declared globally
1001 bytes, patch
Details | Diff | Splinter Review
Patch
684 bytes, patch
naving
: review+
sspitzer
: superreview+
Details | Diff | Splinter Review 
JavaScript strict warning:
chrome://messenger/content/SearchDialog.js line 209: assignment to undeclared 
variable gSearchSession

JavaScript strict warning:
chrome://messenger/content/SearchDialog.js line 220: assignment to undeclared 
variable searchListener

JavaScript strict warning:
chrome://messenger/content/SearchDialog.js line 104: assignment to undeclared 
variable folderResource

JavaScript strict warning:
chrome://messenger/content/SearchDialog.js line 125: assignment to undeclared 
variable gCurrentFolder
Attached patch proposed patch — — Splinter Review 

    
  
Summary: Lots of strict warnings in SearchDialog.js → javascript strict warnings in SearchDialog.js

    
  
Status: NEW → ASSIGNED
Priority: P3 → P5
Target Milestone: --- → Future

    
    

    
  
looks fine to me, although |searchListener| seems to have since been 
removed/changed. r=blake, cc alec for sr

    
    

    
  
gCurrentFolder is a global, (hence the leading "g") can you declare it as such?

    
    

    
  
alec, please sr. thanks.

    
    

    
  
sr=alecf

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
Verified Linux 20010106
Status: RESOLVED → VERIFIED

    
    

    
  
JavaScript strict warning:
chrome://messenger/content/SearchDialog.js line 136: assignment to undeclared 
variable result
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

    
    

    
  
btw also this:
error setting DS on [xpconnect wrapped nsIRDFDataSource]: [Exception... "Compone
nt returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIRDFDataSource.QueryInt
erface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: chrome
://messenger/content/SearchDialog.js :: setMsgDatasourceWindow :: line 325"  dat
a: no]

    
    

    
  
as I recall that "error setting datasource.." stuff is not actually a fatal
condition .. we should just remove the dump()

    
    

    
  
*** Bug 68041 has been marked as a duplicate of this bug. ***

    
  
QA Contact: esther → laurel

    
  
Assignee: blakeross → gayatrib
Status: REOPENED → NEW
QA Contact: laurel → esther

    
    

    
  
These broke after the landing, back to mailnews team.

    
    

    
  
reassigning to naving
Assignee: gayatrib → naving
QA Contact: esther → stephend

    
    

    
  
Comment on attachment 49814 [details] [diff] [review]
Patch

r=naving

        Attachment #49814 -
        Flags: review+

    
    

    
  
Re-assigning to myself.
Assignee: naving → stephend

    
    

    
  
Fixed.
Status: NEW → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
My bad, I missed a warning, so I filed bug 100897.

    
    

    
  
bhart, can you be the neutral verifying party on this bug?

Just enter a search term, hit the Search button, and see if you get the 

JavaScript strict warning:
chrome://messenger/content/SearchDialog.js line 136: assignment to undeclared 
variable result

Just enable JS strict warnings via the Edit | Preferences | Debug | Enable JS 
strict warnings.

If not, thanks anyways.

    
    

    
  
no warnings...
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

    
  
Component: MailNews: Search → MailNews: Message Display
QA Contact: stephend → search

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: