If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

javascript strict warnings in mailWidgets.xml

VERIFIED FIXED

Status

SeaMonkey
MailNews: Message Display
P3
normal
VERIFIED FIXED
17 years ago
9 years ago

People

(Reporter: Henrik Gemal, Assigned: Stephen Walker)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

921 bytes, patch
stephend@netscape.com (gone - use stephen.donner@gmail.com instead)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#search-menulist-abstract.searchScope(
setter) line 2: reference to undefined property this.internalScope

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#search-menulist-abstract.searchScope(
setter) line 2: reference to undefined property this.internalScope

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#searchoperator.valueIds (getter) line 
2: reference to undefined property this.searchAttribute

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#searchoperator.valueIds (getter) line 
2: reference to undefined property this.searchAttribute
(Reporter)

Updated

17 years ago
Summary: Lots of strict warnings in mailWidgets.xml → javascript strict warnings in mailWidgets.xml

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: P3 → P5
Target Milestone: --- → Future

Updated

17 years ago
Assignee: blakeross → gayatrib
Status: ASSIGNED → NEW
Priority: P5 → P3
Target Milestone: Future → ---

Comment 1

17 years ago
gotta focus on xpapps, reassigning to component oner
When you fix this, can someone verify, thanks!

Comment 3

17 years ago
Created attachment 24400 [details] [diff] [review]
patch - fix warnings, remove tabs

Comment 4

17 years ago
This declares the internal elements, but changing them to start with a _ prefix
as well might be a good idea... Also, this isn't thoroughly tested due to the
popup menu breakage of late.

Comment 5

17 years ago
Looks fine to me, r=jag.

cc'ing alecf since this touches mostly his code.

Comment 6

17 years ago
sr=alecf

Comment 7

17 years ago
Checked in, marking fixed.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

17 years ago
JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#searchvalue.value (getter) line 0: re
ference to undefined property this.internalValue
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 9

17 years ago
Hrm... It looks like all these properties will need to be defined as
<property name="foo">null</property> (or false, or 0, whatever their default
init should be);

I'm bugging Brendan and hyatt about whether the old form should be considered
defining the property or not.

Comment 10

17 years ago
Created attachment 26002 [details] [diff] [review]
new patch - declare a few more internal variables

Updated

17 years ago
Assignee: gayatrib → maolson
Status: REOPENED → NEW

Comment 11

17 years ago
r=timeless

Updated

17 years ago
Keywords: approval, patch

Comment 12

17 years ago
sr=alecf

Comment 13

17 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Updated

17 years ago
QA Contact: esther → stephend
Okay, I did a search of messages on my IMAP folders and got no javascript
warnings (selecting a message opened a can of worms wrt strict errors, though,
but that's a seperate issue).
Status: RESOLVED → VERIFIED
(Reporter)

Comment 15

16 years ago
Warning: redeclaration of var menuitem
Source File:
chrome://messenger/content/mailWidgets.xml#search-menulist-abstract.refreshList()
Line: 36, Column: 18
Source Code:
              var menuitem = document.createElement("menuitem");
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 16

16 years ago
Created attachment 61036 [details] [diff] [review]
patch
Comment on attachment 61036 [details] [diff] [review]
patch

r=stephend@netscape.com
Attachment #61036 - Flags: review+
Attachment #24400 - Attachment is obsolete: true
Attachment #26002 - Attachment is obsolete: true
(Assignee)

Comment 18

16 years ago
rs=shaver
Assignee: maolson → walk84
Status: REOPENED → NEW
Fixed.
Status: NEW → RESOLVED
Last Resolved: 17 years ago16 years ago
Resolution: --- → FIXED
Verified FIXED with build 2002-01-06-08 on Windows 2000.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

Updated

9 years ago
Component: MailNews: Search → MailNews: Message Display
QA Contact: stephend → search
You need to log in before you can comment on or make changes to this bug.