58572 - javascript strict warnings in mailWidgets.xml

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#search-menulist-abstract.searchScope(
setter) line 2: reference to undefined property this.internalScope

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#search-menulist-abstract.searchScope(
setter) line 2: reference to undefined property this.internalScope

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#searchoperator.valueIds (getter) line 
2: reference to undefined property this.searchAttribute

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#searchoperator.valueIds (getter) line 
2: reference to undefined property this.searchAttribute

Comment 1

[Blake Ross]

gotta focus on xpapps, reassigning to component oner

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

When you fix this, can someone verify, thanks!

Comment 3

[Mark Olson]

Attachment: patch - fix warnings, remove tabs

Comment 4

[Mark Olson]

This declares the internal elements, but changing them to start with a _ prefix
as well might be a good idea... Also, this isn't thoroughly tested due to the
popup menu breakage of late.

Comment 5

[Peter "jag" Annema]

Looks fine to me, r=jag.

cc'ing alecf since this touches mostly his code.

Comment 6

[Alec Flett]

sr=alecf

Comment 7

[Peter "jag" Annema]

Checked in, marking fixed.

Comment 8

[Henrik Gemal]

JavaScript strict warning:
chrome://messenger/content/mailWidgets.xml#searchvalue.value (getter) line 0: re
ference to undefined property this.internalValue

Comment 9

[Peter "jag" Annema]

Hrm... It looks like all these properties will need to be defined as
<property name="foo">null</property> (or false, or 0, whatever their default
init should be);

I'm bugging Brendan and hyatt about whether the old form should be considered
defining the property or not.

Comment 10

[Mark Olson]

Attachment: new patch - declare a few more internal variables

Comment 11

[timeless]

r=timeless

Comment 12

[Alec Flett]

sr=alecf

Comment 13

[timeless]

fix checked in

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Okay, I did a search of messages on my IMAP folders and got no javascript
warnings (selecting a message opened a can of worms wrt strict errors, though,
but that's a seperate issue).

Comment 15

[Henrik Gemal]

Warning: redeclaration of var menuitem
Source File:
chrome://messenger/content/mailWidgets.xml#search-menulist-abstract.refreshList()
Line: 36, Column: 18
Source Code:
              var menuitem = document.createElement("menuitem");

Comment 16

[Stephen Walker]

Attachment: patch

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 61036 [details] [diff] [review]
patch

r=[e-mail]

Comment 18

[Stephen Walker]

rs=shaver

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

Fixed.

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with build 2002-01-06-08 on Windows 2000.