If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make Mozmill-test testFaviconInAutocomplete local

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: ashughes, Assigned: aaronmt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [litmus-data])

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

7 years ago
Module: testAwesomeBar/testFaviconInAutocomplete.js
Test-page: Use any 1 page from test-files/layout/mozilla*
(Reporter)

Updated

7 years ago
Blocks: 579965
(Assignee)

Updated

7 years ago
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Assignee: aaron.train → nobody
Status: ASSIGNED → NEW
(Assignee)

Comment 1

7 years ago
Created attachment 468313 [details] [diff] [review]
Patch v1 - (default)

cleanup + converts test to make use of local-content
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Attachment #468313 - Flags: review?(anthony.s.hughes)
(Assignee)

Comment 2

7 years ago
Created attachment 468318 [details] [diff] [review]
Patch v1.1 - (default)

Returned the original style constant declaration as demonstrated in the original test, i.e., {url, string}. If the former (v1.0 patch) style (separated declaration) is recommended, I will change back.
Attachment #468313 - Attachment is obsolete: true
Attachment #468318 - Flags: review?(anthony.s.hughes)
Attachment #468313 - Flags: review?(anthony.s.hughes)
(Reporter)

Updated

7 years ago
Attachment #468318 - Flags: review?(hskupin)
Attachment #468318 - Flags: review?(anthony.s.hughes)
Attachment #468318 - Flags: review+
Comment on attachment 468318 [details] [diff] [review]
Patch v1.1 - (default)

>-var setupModule = function(module)
>+var setupModule = function()
> {

nit: braces for functions.

>+  for each (var letter in LOCAL_TEST_PAGE.string) {
>     locationBar.type(letter);
>-    controller.sleep(gDelay);
>+    controller.sleep(200);
>   }
[..]
>-  controller.sleep(gDelay);
>+  controller.sleep(200);

We really should get rid of this sleep call. I would be ok with it here when you file a follow-up bug.

With that r=me.
Attachment #468318 - Flags: review?(hskupin) → review+
(Assignee)

Comment 4

7 years ago
Created attachment 473320 [details] [diff] [review]
Patch v1.2 - [nit fix] (default)

Fixes braces. Will follow up with a new bug for sleep()'s.
Attachment #468318 - Attachment is obsolete: true
(Reporter)

Comment 5

7 years ago
(In reply to comment #4)
> Created attachment 473320 [details] [diff] [review]
> Patch v1.2 - [nit fix] (default)

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/324c390de222

Please followup with 1.9.1 and 1.9.2 patches as necessary.
(Assignee)

Comment 6

7 years ago
Created attachment 473635 [details] [diff] [review]
Patch v1.2 - (1.9.2)
Attachment #473635 - Flags: review?(anthony.s.hughes)
(Reporter)

Comment 7

7 years ago
(In reply to comment #6)
> Created attachment 473635 [details] [diff] [review]
> Patch v1.2 - (1.9.2)

Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/b1e62ee744fb

One thing I noticed about this is that we dont make sure the Awesomebar Autocomplete is closed before ending this test.  We should fix that -- I'll file a separate bug.
(Reporter)

Comment 8

7 years ago
(In reply to comment #7)
> One thing I noticed about this is that we dont make sure the Awesomebar
> Autocomplete is closed before ending this test.  We should fix that -- I'll
> file a separate bug.

Filed -> Bug 594891
(Assignee)

Comment 9

7 years ago
This test doesn't exist on 1.9.1, you can mark this as resolved fixed.
I don't see a difference between the tests for default and 1.9.2. Why we attach separate patches? The 1.9.1 part will be take care of on bug 553618.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

7 years ago
Comment on attachment 473635 [details] [diff] [review]
Patch v1.2 - (1.9.2)

r+ prior to checkin but forgot to flip the flag.  Doing so now.
Attachment #473635 - Flags: review?(anthony.s.hughes) → review+
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Tests
Product: Testing → Mozilla QA
You need to log in before you can comment on or make changes to this bug.