585728 - Make Mozmill-test testFaviconInAutocomplete local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testAwesomeBar/testFaviconInAutocomplete.js
Test-page: Use any 1 page from test-files/layout/mozilla*

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

cleanup + converts test to make use of local-content

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - (default)

Returned the original style constant declaration as demonstrated in the original test, i.e., {url, string}. If the former (v1.0 patch) style (separated declaration) is recommended, I will change back.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 468318 [details] [diff] [review]
Patch v1.1 - (default)

>-var setupModule = function(module)
>+var setupModule = function()
> {

nit: braces for functions.

>+  for each (var letter in LOCAL_TEST_PAGE.string) {
>     locationBar.type(letter);
>-    controller.sleep(gDelay);
>+    controller.sleep(200);
>   }
[..]
>-  controller.sleep(gDelay);
>+  controller.sleep(200);

We really should get rid of this sleep call. I would be ok with it here when you file a follow-up bug.

With that r=me.

Comment 4

[Aaron Train [:aaronmt]]

Attachment: Patch v1.2 - [nit fix] (default)

Fixes braces. Will follow up with a new bug for sleep()'s.

Comment 5

[u279076]

(In reply to comment #4)
> Created attachment 473320 [details] [diff] [review]
> Patch v1.2 - [nit fix] (default)

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/324c390de222

Please followup with 1.9.1 and 1.9.2 patches as necessary.

Comment 6

[Aaron Train [:aaronmt]]

Attachment: Patch v1.2 - (1.9.2)

Comment 7

[u279076]

(In reply to comment #6)
> Created attachment 473635 [details] [diff] [review]
> Patch v1.2 - (1.9.2)

Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/b1e62ee744fb

One thing I noticed about this is that we dont make sure the Awesomebar Autocomplete is closed before ending this test.  We should fix that -- I'll file a separate bug.

Comment 8

[u279076]

(In reply to comment #7)
> One thing I noticed about this is that we dont make sure the Awesomebar
> Autocomplete is closed before ending this test.  We should fix that -- I'll
> file a separate bug.

Filed -> Bug 594891

Comment 9

[Aaron Train [:aaronmt]]

This test doesn't exist on 1.9.1, you can mark this as resolved fixed.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't see a difference between the tests for default and 1.9.2. Why we attach separate patches? The 1.9.1 part will be take care of on bug 553618.

Comment 11

[u279076]

Comment on attachment 473635 [details] [diff] [review]
Patch v1.2 - (1.9.2)

r+ prior to checkin but forgot to flip the flag.  Doing so now.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.