Closed
Bug 585734
Opened 14 years ago
Closed 14 years ago
Disable some c++ unit tests (TestCSSPropertyLookup, TestWinDND) in static builds due to compilation failures
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b4
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
1.10 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
I was hoping not to have to do this, but I for Thunderbird we're hooking up a new try server and will be doing some packaged tests - which will be the first time we've had tests on try, and we are hoping it will cut down review time and reduce errors before landing (and then I can get onto sorting out libxul builds). In any case, to get our new packaged try server Windows builds completing with --enable-tests, we need to disable a couple of c++ unit tests (make check) in mozilla-central. I see no harm in doing this as they are disabled for libxul anyway. Patch attached to do the disabling.
Assignee | ||
Updated•14 years ago
|
Attachment #464158 -
Flags: review?(me)
Comment on attachment 464158 [details] [diff] [review] The fix We really need a better way to do C++ unit tests in general.
Attachment #464158 -
Flags: review?(me) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 464158 [details] [diff] [review] The fix I quite agree. Requesting approval for this build-config only patch which won't change the Firefox build.
Attachment #464158 -
Flags: approval2.0?
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 464158 [details] [diff] [review] The fix So actually looking at the tree rules, this appears to come under the test-only banner as it only affects build config in test specific directories. Therefore cancelling approval request.
Attachment #464158 -
Flags: approval2.0?
Assignee | ||
Comment 4•14 years ago
|
||
Checked in: http://hg.mozilla.org/mozilla-central/rev/0de04ae0386f
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•