Closed Bug 585734 Opened 10 years ago Closed 10 years ago
Disable some c++ unit tests (Test
CSSProperty Lookup, Test Win DND) in static builds due to compilation failures
I was hoping not to have to do this, but I for Thunderbird we're hooking up a new try server and will be doing some packaged tests - which will be the first time we've had tests on try, and we are hoping it will cut down review time and reduce errors before landing (and then I can get onto sorting out libxul builds). In any case, to get our new packaged try server Windows builds completing with --enable-tests, we need to disable a couple of c++ unit tests (make check) in mozilla-central. I see no harm in doing this as they are disabled for libxul anyway. Patch attached to do the disabling.
Comment on attachment 464158 [details] [diff] [review] The fix We really need a better way to do C++ unit tests in general.
Attachment #464158 - Flags: review?(me) → review+
Comment on attachment 464158 [details] [diff] [review] The fix I quite agree. Requesting approval for this build-config only patch which won't change the Firefox build.
Comment on attachment 464158 [details] [diff] [review] The fix So actually looking at the tree rules, this appears to come under the test-only banner as it only affects build config in test specific directories. Therefore cancelling approval request.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in before you can comment on or make changes to this bug.