585766 - Make Mozmill-test testDisableFormManager local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testFormManager/testDisableFormManager.js
Test-page: test-files/form_manager/form.html

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

cleanup + converts test to make use of local-data

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 469544 [details] [diff] [review]
Patch v1 - (default)

>-const gTimeout = 200;
>+const TIMEOUT = 200;

Please rename it to a more specific timeout value. It's not the general timeout we use everywhere else.

>+  var submitButton = new elementslib.ID(controller.tabs.activeTab, "SubmitButton");

Please move the declaration up to the other elements.

>+  var popDownAutoCompList = new elementslib.Lookup(controller.window.content.document, 
>+                                                   '/id("main-window")' + 
>+                                                   '/id("mainPopupSet")' + 
>+                                                   '/id("PopupAutoComplete")' + 
>+                                                   '/anon({"anonid":"tree"})' + 
>+                                                   '/{"class":"autocomplete-treebody"}');

As talked on another bug please use 2 blanks for indentation of all parameters from the beginning of the line.

r=me with those changes.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - (default)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 475404 [details] [diff] [review]
Patch v1.1 - (default)

>+  var popDownAutoCompList = new elementslib.Lookup(controller.window.content.document, 
>+  '/id("main-window")' + 
>+  '/id("mainPopupSet")' + 
>+  '/id("PopupAutoComplete")' + 
>+  '/anon({"anonid":"tree"})' + 
>+  '/{"class":"autocomplete-treebody"}');

Looks like we have to step back here. :/ This formatting makes no sense and is completely confusing. Sorry for the last comment on that. I should have tried it out. Please use the following indentation which will also give us enough space even for longer names:

>+  var popDownAutoCompList = new elementslib.Lookup(controller.window.content.document, 
>+                              '/id("main-window")' + 
>+                              '/id("mainPopupSet")' + 

And by the way:

>+  var popDownAutoCompList = new elementslib.Lookup(controller.window.content.document, 

Shouldn't this be controller.tabs.activeTab?

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Patch v1.2 - (default)

Sorry for the delay on this. I think I was working on it on the plane to MV last week and forgot about it. As per comment #4, I took the exact same style you wrote out in a bug yesterday, about functions calls vs. assignments.

Comment 6

[u279076]

Comment on attachment 477688 [details] [diff] [review]
Patch v1.2 - (default)

>+  var popDownAutoCompList = new elementslib.Lookup(
>+                              controller.tabs.activeTab, 
>+                              '/id("main-window")' + 
>+                              '/id("mainPopupSet")' + 
>+                              '/id("PopupAutoComplete")' + 
>+                              '/anon({"anonid":"tree"})' + 
>+                              '/{"class":"autocomplete-treebody"}'
>+  );

r+ with the following suggestion...

The ); should be aligned to the 'n' in 'new'.  I can make this change prior to check-in, but please do this in the future.  Thanks.

Comment 7

[u279076]

> Created attachment 477688 [details] [diff] [review]
> Patch v1.2 - (default)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/4e6c1b6c7081 [default]

Please provide patches for mozilla1.9.2 and mozilla1.9.1

Comment 8

[Aaron Train [:aaronmt]]

Attachment: Patch v1.2 - (1.9.2)

Comment 9

[Aaron Train [:aaronmt]]

Attachment: Patch v1.2 - (1.9.1)

Comment 10

[u279076]

(In reply to comment #8)
> Created attachment 478089 [details] [diff] [review]
> Patch v1.2 - (1.9.2)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/db1df396a7e3 [mozilla1.9.2]

Comment 11

[u279076]

(In reply to comment #9)
> Created attachment 478090 [details] [diff] [review]
> Patch v1.2 - (1.9.1)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/5b4b853089fe [mozilla1.9.1]

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.