Closed Bug 585774 Opened 12 years ago Closed 12 years ago

Revert in tree pymake to a pre-native-commands version

Categories

(Firefox Build System :: General, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: khuey, Unassigned)

Details

Builds with the new pymake take twice as long as they used to.  We should improve the native commands version, but for the moment we need to revert to the good pymake.
http://hg.mozilla.org/mozilla-central/rev/f79e708777c8
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Version: unspecified → Trunk
Bummer. I kind of hoped someone would have timed some builds with it. I only ever tested that it worked, not how fast it was. I assume there's a larger fixed overhead for starting the process pool, but I would think that'd be a fixed cost amortized across the entire run. It's possible that the new synchronization code is slower than the old WaitForMultipleObjects type.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.