Closed Bug 585847 Opened 14 years ago Closed 14 years ago

Remove -DUSE_DEBUG_RTL, and call PL_ArenaFinish before PR_Cleanup in pk12util

Categories

(NSS :: Build, defect)

Product:
NSS
Version:
3.12.7
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
3.12.8

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(2 files)

Remove -DUSE_DEBUG_RTL (checked in)
877 bytes, patch
wtc
: review?
christophe.ravel.bugs
nelson
: superreview+
Details | Diff | Splinter Review
Call PL_ArenaFinish before PR_Cleanup (checked in)
768 bytes, patch
nelson
: review+
Details | Diff | Splinter Review 
The patch in bug 562636 added -DUSE_DEBUG_RTL
to mozilla/security/coreconf/WIN32.mk, but
USE_DEBUG_RTL is a build variable, not a C
preprocessor macro.  As this MXR query shows,
there is no C code that tests the USE_DEBUG_RTL
macro:
http://mxr.mozilla.org/security/search?string=USE_DEBUG_RTL

The proposed patch removes -DUSE_DEBUG_RTL.
Attachment #464276 - Flags: superreview?(nelson)
Attachment #464276 - Flags: review?(christophe.ravel.bugs)
It is safer to destroy things from top to bottom,
just in case the destruction function of a higher
layer (libplds4) calls a function in a lower layer
(libnspr4).
Attachment #464278 - Flags: review?(nelson)
Attachment #464276 - Attachment description: Proposed patch → Remove -DUSE_DEBUG_RTL
Attachment #464278 - Flags: review?(nelson) → review+
Comment on attachment 464276 [details] [diff] [review]
Remove -DUSE_DEBUG_RTL (checked in)

I had originally added some code that was #ifdef USE_DEBUG_RTL 
but I changed it to #ifdef _CRT_MAP_ALLOC and forgot to remove the 
USE_DEBUG_RTL  symbol from the Makefile.
Attachment #464276 - Flags: superreview?(nelson) → superreview+
Comment on attachment 464276 [details] [diff] [review]
Remove -DUSE_DEBUG_RTL (checked in)

I checked in this patch on the NSS trunk (NSS 3.13)
and NSS_3_12_BRANCH (NSS 3.12.8).

Checking in WIN32.mk;
/cvsroot/mozilla/security/coreconf/WIN32.mk,v  <--  WIN32.mk
new revision: 1.41; previous revision: 1.40
done

Checking in WIN32.mk;
/cvsroot/mozilla/security/coreconf/WIN32.mk,v  <--  WIN32.mk
new revision: 1.39.2.2; previous revision: 1.39.2.1
done
Attachment #464276 - Attachment description: Remove -DUSE_DEBUG_RTL → Remove -DUSE_DEBUG_RTL (checked in)
Comment on attachment 464278 [details] [diff] [review]
Call PL_ArenaFinish before PR_Cleanup (checked in)

I checked in the patch on the NSS trunk (NSS 3.13)
and NSS_3_12_BRANCH (NSS 3.12.8).

Checking in pk12util.c;
/cvsroot/mozilla/security/nss/cmd/pk12util/pk12util.c,v  <--  pk12util.c
new revision: 1.45; previous revision: 1.44
done

Checking in pk12util.c;
/cvsroot/mozilla/security/nss/cmd/pk12util/pk12util.c,v  <--  pk12util.c
new revision: 1.44.2.1; previous revision: 1.44
done
Attachment #464278 - Attachment description: Call PL_ArenaFinish before PR_Cleanup → Call PL_ArenaFinish before PR_Cleanup (checked in)
Severity: trivial → minor
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Summary: Remove -DUSE_DEBUG_RTL, added in bug 562636 → Remove -DUSE_DEBUG_RTL, and call PL_ArenaFinish before PR_Cleanup in pk12util
Target Milestone: 3.13 → 3.12.8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: