Closed Bug 585927 Opened 12 years ago Closed 12 years ago

Mail bloat tests need upgrading to account for manifest changes


(MailNews Core :: Testing Infrastructure, defect)

Not set


(Not tracked)

Thunderbird 3.3a1


(Reporter: standard8, Assigned: standard8)



(1 file)

Attached patch The fixSplinter Review
The recent manifest changes to only read from specific manifest files mean that the mail bloat tests (which were creating their own .manifest file and putting it into the chrome directory) are now broken.

These need upgrading so we can get the tree green again.

What I've done:

- Made mail bloat into an extension. The extension now does the required registrations, and it also contains the preferences file (previously the preferences file was put into the created profile folder, but this is probably simpler).

- Removed the mailnews/test/performance/common code, moving the preferences to the bloat directory. This just makes it a simpler set up, and reflects the fact that nothing else is currently using those preferences.

- Does away with the additional setup scripts - these are no longer required now that we can just use automation.installExtension.

Requesting review from Justin, as I think he's got the experience to review all of this. Though others can jump in as well if they can get to it before him.
Attachment #464391 - Flags: review?(bugspam.Callek)
Comment on attachment 464391 [details] [diff] [review]
The fix

bwinton's given me r over irc for this.
Attachment #464391 - Flags: review?(bugspam.Callek)
(In reply to comment #1)
> Comment on attachment 464391 [details] [diff] [review]
> The fix
> bwinton's given me r over irc for this.

I'll still review... sorry for the delay though [stupid actual bustages delayed me]
Hrm, I checked this in a while ago, closing (Callek is welcome to add comments if necessary).
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.