Closed Bug 585994 Opened 12 years ago Closed 12 years ago

Mozmill tests print the "Application Disconnect" error on user initiated shutdown

Categories

(Testing Graveyard :: Mozmill, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ahal, Assigned: ahal)

Details

(Whiteboard: [mozmill-1.4.2+])

Attachments

(1 file)

This doesn't affect mozmill-restart tests because the mozmill-restart class intercepts the JSBridgeDisconnect exception (something that the mozmill class has no need to do).

A hard kill option was introduced in bug 579791 which helps out a lot for ending left over firefox processes (for example when the user ends a mozmill test by restarting the browser).  However at the moment using this hard kill also results in an "Application Disconnect" error being printed to stdout which shouldn't be printed if the user (test) shutdown the browser.
Moves the userShutdown_listener out of the mozmill-restart class and into the mozmill class.
Attachment #464463 - Flags: review?(jhammel)
Assignee: nobody → ahalberstadt
Whiteboard: [mozmill-1.4.2?]
Comment on attachment 464463 [details] [diff] [review]
Doesn't print error if browser was shutdown purposefully

>             except JSBridgeDisconnectError:
>                 disconnected = True
>-                print 'TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed'
>+                if not self.mozmill.userShutdownEnabled:                    
>+                    print 'TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed'

I don't like this condition here for the reason that the CLI is acting as a controller.  We can take this for 1.4.2 but really this logic should live internal to Mozmill itself (as should the printing, which should really be logging.
Attachment #464463 - Flags: review?(jhammel) → review+
Think we should take this at it relates to a recently-added feature, and has been tested on restart tests for a long time.
Whiteboard: [mozmill-1.4.2?] → [mozmill-1.4.2+]
master: http://github.com/mozautomation/mozmill/commit/a1f59fd4c38674735a0113982a617f0726bbf062

1.4.2: http://github.com/mozautomation/mozmill/commit/983e148c404fe1b90585c2524ebc2cd51905218f

The 'test/test_userShutdown.js' has been modified with this commit and should pass.  In addition both 'test/restart/test_user_restart/test1.js' and 'test/restart/test_user_restart/test2.js' should pass when run as a normal mozmill test (instead of mozmill-restart).
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> master:
> http://github.com/mozautomation/mozmill/commit/a1f59fd4c38674735a0113982a617f0726bbf062
> 
> 1.4.2:
> http://github.com/mozautomation/mozmill/commit/983e148c404fe1b90585c2524ebc2cd51905218f
> 
> The 'test/test_userShutdown.js' has been modified with this commit and should
> pass.  In addition both 'test/restart/test_user_restart/test1.js' and
> 'test/restart/test_user_restart/test2.js' should pass when run as a normal
> mozmill test (instead of mozmill-restart).

Verified fixed trying out these tests on a master clone build and install, all three pass.
Status: RESOLVED → VERIFIED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.