Closed Bug 586122 Opened 9 years ago Closed 9 years ago

Clusters do not get cleared with switching Sync profiles

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: tchung, Assigned: mfinkle)

Details

Attachments

(1 file)

I run into 401 cluster errors when switching and syncing different profiles.  As zandr points out, its likely because the clusters aren't clearing out correctly after disconnect.

Repro:
1) install sync 1.4.4b2 and sync with accountA
2) check activity log and note which cluster it sync'd on (eg. phx-sync387.services.mozilla.com)
3) disconnect, then change profiles and log in with a accountB, and connect
4) Verify activity log throws an error and retries with a different cluster:

GET fail 401 https://phx-sync387.services.mozilla.com/1.0/fennecqa/info/collections
Finding cluster for user fennecqa
GET success 200 https://auth.services.mozilla.com/.....
cluster value = https://phx-sync294.services.mozilla.com

Expected:
- disconnecting accountA and connecting accountB should not fail a 401 due to last known good cluster for that account
This sounds like the client not clearing the URL when we switch profiles, so I don't think it's a server issue.
Assignee: telliott → nobody
Component: Server → General
QA Contact: server → general
Er, we wipe all user prefs on start over, which is where we store the cluster, so this shouldn't happen.  Unless "change profiles" means "use a different, already-configured profile with a different account" in which case this would only be an issue if profiles were generally horked.

Note that we've migrated a bunch of users around the cluster, so if the profile was stale, that'd be possibly-expected... can you repro this from scratch?  And can you verify that the 401 is on the same shard as account A was using?
i shoulda add the minor detail that this was using the Fennec Sync client to test this.   

I just checked desktop firefox, and it seems to clear clusters just fine.  (services.sync.clusterURL gets reset)
The Fennec UI doesn't call Weave.Service.startOver() when the account changes. That means it engines aren't being reset either.
Component: General → Fennec UI
OS: Mac OS X → All
QA Contact: general → fennec
Hardware: x86 → All
Attached patch patchSplinter Review
Patch based on some discussion with friendly #labs people
Assignee: nobody → mark.finkle
Attachment #465101 - Flags: review?(philipp)
Attachment #465101 - Flags: review?(philipp) → review+
Filed follow up bug 586615 for the add-on, moving this bug to the Fennec -> Sync component.
Component: Fennec UI → General
Product: Weave → Fennec
QA Contact: fennec → general
Version: unspecified → Trunk
pushed:
http://hg.mozilla.org/mobile-browser/rev/823bb6e95990
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fix on Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b4pre) Gecko/20100820 Namoroka/4.04pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.