586163 - Document the change to PKCS #12 nickname collision callback in NSS 3.12

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Wan-Teh Chang]

Attachment: Proposed patch

In bug 321584 (fixed in NSS 3.12), the third argument
to the PKCS #12 nickname collision callback changed
from wincx to leafCert.  See r1.35 of p12d.c
(attachment 218454 [details] [diff] [review]).

This fact is useful to people who write nickname
collision callbacks.  The proposed patch adds a
comment to the definition of SEC_PKCS12NicknameCollisionCallback
in p12.h to document this.  It also removes several
unused 'wincx' arguments.

This MXR query shows nicknameCb is invoked in only
one place, inside sec_pkcs12_validate_cert_nickname:
http://mxr.mozilla.org/security/ident?i=nicknameCb

The last argument to that nicknameCb call is the
last argument of sec_pkcs12_validate_cert_nickname.

And sec_pkcs12_validate_cert_nickname is called in
only one place, with 'leafCert' as the last argument:
http://mxr.mozilla.org/security/ident?i=sec_pkcs12_validate_cert_nickname

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 464684 [details] [diff] [review]
Proposed patch

r=nelson

Comment 2

[Wan-Teh Chang]

Patch checked in on the NSS trunk (NSS 3.13).

Checking in p12.h;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12.h,v  <--  p12.h
new revision: 1.13; previous revision: 1.12
done
Checking in p12d.c;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12d.c,v  <--  p12d.c
new revision: 1.50; previous revision: 1.49
done