586194 - move never pref check into selectUpdate and use services js module in app update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

The never pref check should be in selectUpdate since the never button can now be shown for both minor and major updates. I also would like to make app update use the services js module but can move that to a separate bug if preferred.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 with test

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

After thinking about it I don't think the never pref should be cleared for background updates and instead it should just be ignored if the update doesn't specify showNeverForVersion.

Comment 3

[Robert Strong (they/them - no direct email)]

btw: do you think the new test would be better as an xpcshell test? I should be able to test no updates due to the pref that way

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 464759 [details] [diff] [review]
patch rev2

I think the test is fine as-is

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 464759 [details] [diff] [review]
patch rev2

Drivers, this adds a better solution for bug 350636 and makes app update use Services.jsm as much of the other code base has recently done.

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/c727df97c28c