586233 - Top window border not painted on Classic desktops with custom active/inactive window colors

Status: NEW

(Core :: Widget: Win32, defect)

Description

[Stanimir Stamenkov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.24) Gecko/20100228 SeaMonkey/1.1.19 (Spidey; Mnenhy 0.7.6)
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre

With the introduction of the title-bar drawn appmenu-button the top window border doesn't seem painted with the corresponding active or inactive color anymore - using Classic style theme.  To see this, explicitly configure the "Active Window Border" and "Inactive Window Border" colors to something distinguishable.

Reproducible: Always

Comment 1

[Stanimir Stamenkov]

This could be related with Bug 586228.

Comment 2

[Stanimir Stamenkov]

Attachment: Classic theme window border color settings

Comment 3

[Stanimir Stamenkov]

Attachment: Active window top border not painted

Comment 4

[Stanimir Stamenkov]

Attachment: Inactive window top border not painted

Comment 5

[Stanimir Stamenkov]

Attachment: Classic theme - top border painted with Personas image

Comment 6

[Stanimir Stamenkov]

Attachment: XP-style theme - top border not painted with Personas image

Comment 7

[Stanimir Stamenkov]

If the general intention is to let Personas draw over the window borders, all borders should be drawn when no persona has been applied, at least.  But I guess the given case of Personas drawn over the top border is just unwanted effect?

Comment 8

[Stanimir Stamenkov]

This appears to happen only with browser windows which have the app-menu button
shown.  When I permanently show the menu bar and the app-menu button disappears
the top border starts to paint all right (Personas not painting over, too).

Comment 9

[Jim Mathies [:jimm]]

(In reply to comment #7)
> If the general intention is to let Personas draw over the window borders, all
> borders should be drawn when no persona has been applied, at least.  But I
> guess the given case of Personas drawn over the top border is just unwanted
> effect?

With the default color scheme, the titlebar obscures the persona, which is desired. Setting these custom active border values causes the upper border painting to skip, so the persona shows up. Not sure why but this shouldn't be hard to track down.

http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsNativeThemeWin.cpp#3190

Comment 10

[Jim Mathies [:jimm]]

Hmm, looks like DrawFrameControl and DrawEdge are lacking for this. We might have to put this edge together manually.

Comment 11

[Jim Mathies [:jimm]]

(In reply to comment #6)
> Created attachment 464771 [details]
> XP-style theme - top border not painted with Personas image

Stanimir, what's the issue here on XP?

Comment 12

[Stanimir Stamenkov]

>> Created attachment 464771 [details] [details]
>> XP-style theme - top border not painted with Personas image
> 
> Stanimir, what's the issue here on XP?

No issue/problem - just for comparison.

Comment 13

[Jim Mathies [:jimm]]

This should probably block, our classic rendering isn't right when user's customize through advanced ui prefs.

Comment 14

[Joe Drew (not getting mail)]

I don't really think this blocks. I'd take the patch, but it feels like this would be a bug that falls off the back of the bus.

Comment 15

[Jim Mathies [:jimm]]

Attachment: attempt v.1

This patch addresses this, although there's a bug where the highlighted border sometimes is offset one pixel too high on the window, depending on the border width.

I haven't been able to track that last problem down. If someone feels passionately about this feel free to take this up. I'll try to get back to this before the release or shortly after.

Comment 16

[Jim Mathies [:jimm]]

(note that patch is built on top of the patches in bug 610643)

Comment 17

[Stanimir Stamenkov]

Still seen using: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110222 Firefox/4.0b12pre

Comment 18

[BS]

Thunderbird v60/v68

Win 7 x86
Classic theme

Top Active-Window-Border is missing in the main window:

(It's OK when mail.tabs.autoHide=True.)

(Other windows are OK.)

Comment 19

[BS]

▲Image:
https://bugzilla.mozilla.org/attachment.cgi?id=9121976