Open Bug 586242 Opened 9 years ago Updated 3 months ago

Key assigned to toggle toolbar doesn't show in Firefox toolbar menus

Categories

(Firefox :: Toolbars and Customization, defect)

x86
Windows 7
defect
Not set

Tracking

()

UNCONFIRMED

People

(Reporter: bugzilla.mozilla.org, Unassigned)

Details

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b2) Gecko/20100720 Firefox/4.0b2
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b2) Gecko/20100720 Firefox/4.0b2

Let's say we have the following XUL code:

<toolbox id="navigator-toolbox">
  <toolbar id="example_toolbar" class="chromeclass-toolbar"
  toolbarname="Example" key="example_key_toggle_toolbar"
  chromeclass="toolbar" defaultset="" context="toolbar-context-menu"/>
</toolbox>
<keyset id="mainKeyset">
  <key id="example_key_toggle_toolbar" keycode="VK_F9" keytext="F9"
  command="example_command_toggle_toolbar"/>
</keyset>
<commandset id="mainCommandSet">
  <command id="example_command_toggle_toolbar"
  oncommand="goToggleToolbar('example_toolbar',
  'example_command_toggle_toolbar');"/>
</commandset>

The name of the toolbar will automatically show up as a menu item in both the View > Toolbars menu and the toolbars' context menu, allowing the toolbar to be shown or hidden. However the Firefox code that is adding the toolbar to the menus does not appear to be checking if the toolbar has a key assigned to it and then displaying the key's shortcut alongside the menuitem label.

I realise that we could simply include the key shortcut in the name of the toolbar but it would be nice if this was fixed so that it appears as a proper menu shortcut.

Reproducible: Always
You need to log in before you can comment on or make changes to this bug.