58631 - javascript strict warnings in history.js

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/history/history.js line 83: trailing comma is not
legal in ECMA-262 object initializers

JavaScript strict warning:
chrome://communicator/content/history/history.js line 102: trailing comma is not
legal in ECMA-262 object initializers

Comment 1

[Jarrod Gray]

Attachment: proposed patch

Comment 2

[Radha on family leave (not reading bugmail)]

My guess this is something to do with global history. Session History does not 
use a file like that. cc'ing rjc and matt

Comment 3

[Radha on family leave (not reading bugmail)]

giving to rjc, since this is global history

Comment 4

[Alec Flett]

taking this...Adding jag for review

Comment 5

[Blake Ross]

I'm not jag (a good thing? ;), but r=blake ...

Comment 6

[Alec Flett]

thanks jarrod, blake
fix is in.

Comment 7

[Mark Olson]

New warnings crept in:

JavaScript strict warning:
chrome://communicator/content/history/history.js line 74: function OpenURL does
not always return a value

Patch coming right up.

Comment 8

[Mark Olson]

Attachment: patch - fix new warnings

Comment 9

[Peter "jag" Annema]

r=jag

Shame on you, Alec and Blake! <gd&r>

(And yes, a good thing indeed you are not I. Otherwise you'd be making a whole
lot more mistakes ;-) )

Comment 10

[Alec Flett]

sr=alecf, thanks jag :)

Comment 11

[Blake Ross]

Fix checked in.

Comment 12

[Henrik Gemal]

verified with build 20010126 on win2k

Comment 13

[Henrik Gemal]

JavaScript strict warning:
chrome://communicator/content/history/history.js line 89: redeclaration of var 
match

Comment 14

[Henrik Gemal]

btw:
JavaScript error:
chrome://communicator/content/history/history.js line 77: gHistoryTree has no 
properties

Comment 15

[Alec Flett]

henrik, how did you get that second one? I can't figure out how that would even
happen.
attaching a new patch that fixes the first warning most recently listed, as well
as removing dumps()

Comment 16

[Alec Flett]

Attachment: warnings fix, plus removal of dumps

Comment 17

[Blake Ross]

r=blake
yeah, that second warning is weird.

Comment 18

[Henrik Gemal]

I'm not sure how I got the other one. I been through the history and couldn't 
get it in todays build...

Comment 19

[Henrik Gemal]

Just got the error!
It was when I click on a history item in the History sidebar! I get it everytime 
I click on a item in the history sidebar....

Comment 20

[Stephen Walker]

*** Bug 69871 has been marked as a duplicate of this bug. ***

Comment 21

[Mark Olson]

Attachment: patch - call init function in history panel

Comment 22

[Mark Olson]

This patch calls history.js' init routine for the panel so that the globals get
set up.  (To be taken along w/ alecf's most recent patch).

Comment 23

[Alec Flett]

sr=alecf
thanks!

Comment 24

[Mark Olson]

Ok, so my latest patch needs r=, and alec's patch needs sr= (both are necessary
to fix all current warnings)

Comment 25

[Peter "jag" Annema]

r=jag

Comment 26

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 27

[Alec Flett]

both fixes checked in.

Comment 28

[timeless]

vrfy history 1.19, panel 1.2

Comment 29

[Henrik Gemal]

Warning: anonymous function does not always return a value
Source File: chrome://communicator/content/history/history.js
Line: 199, Column: 2
Source Code:  }

build 20010527

Comment 30

[basic]

Attachment: patch: add a return true to onDragStart

Comment 31

[Alec Flett]

reassign to blake..

Comment 32

[jag (Peter Annema)]

Reassigning to blake as per alecf's comment.

Comment 33

[Blake Ross]

this is fixed.

Comment 34

[Henrik Gemal]

Verified fixed in 20020115. Will reopen if I see these warnings again...