Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Maemo5/6 seems not compiling due to some Qt include conflicts and cast problems

Need to fix that
(Assignee)

Comment 1

8 years ago
First problem is maemo6:
nsLocaleService.cpp:192: error: invalid conversion from 'const char*' to 'char*'

grr, my fault, I took wrong conversion from previous patch.

Another problem is that qt includes does not like malloc/realloc and others defined before...
Blocks: 582032
(Assignee)

Comment 2

8 years ago
Created attachment 464877 [details] [diff] [review]
Qt includes problem
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #464877 - Flags: review?(jones.chris.g)
(Assignee)

Comment 3

8 years ago
Created attachment 464880 [details] [diff] [review]
char cast problem, use const pointer
Attachment #464880 - Flags: review?
Comment on attachment 464877 [details] [diff] [review]
Qt includes problem

If MozMeegoAppService.h ever includes a Gecko header, we're going to get another build bustage, but this is fine for now.  Man I hate these header shenanigans :|.
Attachment #464877 - Flags: review?(jones.chris.g) → review+
(Assignee)

Updated

8 years ago
Attachment #464880 - Flags: review? → review?(benjamin)

Updated

8 years ago
Attachment #464880 - Flags: review?(benjamin) → review+
(Assignee)

Updated

8 years ago
Attachment #464880 - Flags: approval2.0?
(Assignee)

Comment 5

8 years ago
dougt can we land it?
Keywords: checkin-needed

Comment 6

8 years ago
of course.  a=buildbustage.

Just follow the tree rules.
(Assignee)

Comment 7

8 years ago
Comment on attachment 464880 [details] [diff] [review]
char cast problem, use const pointer

no approval for bustage fix
Attachment #464880 - Flags: approval2.0?
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b5039f0659ca
http://hg.mozilla.org/mozilla-central/rev/812cdded39a1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.