586325 - Maemo5/6 build bustage

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

Maemo5/6 seems not compiling due to some Qt include conflicts and cast problems

Need to fix that

Comment 1

[Oleg Romashin (:romaxa)]

First problem is maemo6:
nsLocaleService.cpp:192: error: invalid conversion from 'const char*' to 'char*'

grr, my fault, I took wrong conversion from previous patch.

Another problem is that qt includes does not like malloc/realloc and others defined before...

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Qt includes problem

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: char cast problem, use const pointer

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 464877 [details] [diff] [review]
Qt includes problem

If MozMeegoAppService.h ever includes a Gecko header, we're going to get another build bustage, but this is fine for now.  Man I hate these header shenanigans :|.

Comment 5

[Oleg Romashin (:romaxa)]

dougt can we land it?

Comment 6

[Doug Turner (:dougt)]

of course.  a=buildbustage.

Just follow the tree rules.

Comment 7

[Oleg Romashin (:romaxa)]

Comment on attachment 464880 [details] [diff] [review]
char cast problem, use const pointer

no approval for bustage fix

Comment 8

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/b5039f0659ca
http://hg.mozilla.org/mozilla-central/rev/812cdded39a1