586401 - Potential vulnerability left after the patch in bug 585284

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: wip

The patch in bug 585284 fixes the testcase in that bug, but I don't think that it deals with the cached principal stuff that is supposed to protect SJOWs from being used to access objects that the original caller doesn't have access to (I don't fully understand what it's supposed to do at the moment).

I don't know if this is actually exploitable, but I wanted to file a bug just in case...

Comment 1

[Johnny Stenback (:jst)]

Blake, I'm assuming this is fixed on trunk now, but we still need this for the older branches, right?

Comment 2

[Johnny Stenback (:jst)]

mrbkap, can you comment on this wrt current trunk vs branches?

Comment 3

[Johnny Stenback (:jst)]

Blake, this is a non-issue on trunk now, right?

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Yes.

Comment 5

[Johnny Stenback (:jst)]

Excellent, marking as such.

Comment 6

[Johnny Stenback (:jst)]

Given that we have no known way to exploit this, and no testcase, this doesn't seem worth fixing for 3.6 at this time. If someone can come up with a testcase then that's something we could look into, but as of now we have no testcase.

Comment 7

[Alex Keybl [:akeybl]]

Thanks Johnny - that sounds reasonable. Marking as wontfix for 1.9.2.

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Resolving "fixed" since this has apparently been fixed for months but I know of no way to verify.