Separate structural versus visual CSS

RESOLVED FIXED in Firefox 4.0b5

Status

Firefox Graveyard
Panorama
P2
normal
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: iangilman, Assigned: mitcho)

Tracking

Trunk
Firefox 4.0b5
Dependency tree / graph

Details

(Whiteboard: b4 [qa-])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
As per dolske, in his review of bug 574217: 

Most of the contents of browser/base/content/tabview/tabview.css should move
into browser/themes/*/browser/tabview/tabview.css, so that appearance is
controllable by 3rd party themes. The rough guideline, AIUI, is to have
structural/functional rules in /content  (eg various position: absolute,
z-index, 100% width/height), and appearance rules in /themes (colors, images,
shadows, borders). EG, compare browser/base/content/browser.css with
browser/themes/winstripe/browser/browser.css. I don't think this needs to block
the initial landing, but it should probably be sorted out before the beta (so
themers don't scream at us too loudly). File a followup?
(Reporter)

Updated

8 years ago
Depends on: 574217

Updated

8 years ago
Whiteboard: b4

Updated

8 years ago
Blocks: 586788

Updated

8 years ago
Priority: -- → P2

Comment 1

8 years ago
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---

Updated

8 years ago
QA Contact: tabcandy → tabcandy
(Assignee)

Comment 2

8 years ago
I will do a first pass of this right now in preparation for bug 590742.
Blocks: 590742
Status: NEW → ASSIGNED
QA Contact: tabcandy → mitcho
(Assignee)

Comment 3

8 years ago
Created attachment 469659 [details] [diff] [review]
Proposed patch
Attachment #469659 - Flags: review?(dolske)
(Assignee)

Updated

8 years ago
Target Milestone: --- → Firefox 4.0b5
(Assignee)

Updated

8 years ago
Assignee: nobody → mitcho
QA Contact: mitcho → tabcandy
(Assignee)

Comment 4

8 years ago
Created attachment 469680 [details] [diff] [review]
Fixed one CSS chunk which was redundant
Attachment #469659 - Attachment is obsolete: true
Attachment #469680 - Flags: review?(dolske)
Attachment #469659 - Flags: review?(dolske)
(Assignee)

Updated

8 years ago
No longer blocks: 586788
(Assignee)

Updated

8 years ago
Depends on: 586549
Comment on attachment 469680 [details] [diff] [review]
Fixed one CSS chunk which was redundant

>+++ b/browser/base/content/tabview/tabview.css
...
> .stacked .thumb {
>   -moz-box-shadow: rgba(0,0,0,.2) 1px 1px 6px;
> }

Ought this be moved as well?

Also, are diffs between the 3 browser/themes/*/browser/tabview/tabview.css files sensibly minimal? Keeping the 3 platform themes in sync is obviously easier when the files are as identical as possible.
Attachment #469680 - Flags: review?(dolske)
Attachment #469680 - Flags: review+
Attachment #469680 - Flags: approval2.0+
(Assignee)

Comment 6

8 years ago
Created attachment 471247 [details] [diff] [review]
Patch for checkin
Attachment #469680 - Attachment is obsolete: true

Comment 7

8 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/c20332ee8c6b
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 8

8 years ago
Awesome, thanks Clint!

Comment 9

8 years ago
There is still a lot of styling in tabview.js. This should also be moved to tabview.css:
393          "padding-left": pad + "px",
394          "padding-right": pad + 2 + "px",
395          "padding-top": pad + "px",
396          "padding-bottom": pad + "px",
397          "border-color": "rgba(0,0,0,"+ alphaRange.scale(proportion) +")",
Especially the border-color should not be generated from .js.
(In reply to comment #9)
> There is still a lot of styling in tabview.js. This should also be moved to
> tabview.css:
> 393          "padding-left": pad + "px",
> 394          "padding-right": pad + 2 + "px",
> 395          "padding-top": pad + "px",
> 396          "padding-bottom": pad + "px",
> 397          "border-color": "rgba(0,0,0,"+ alphaRange.scale(proportion) +")",
> Especially the border-color should not be generated from .js.

A number of bugs exist for removing styling in js, or making them be based on themeable CSS. Please open a separate bug for this issue.

Updated

8 years ago
Whiteboard: b4 → b4 [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.