586499 - TM: Yarr mochitest failure browser_plainTextLinks.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Leary [:cdleary] (not checking bugmail)]

TEST-START | chrome://mochikit/content/browser/browser/base/content/test/browser_plainTextLinks.js
TEST-INFO | chrome://mochikit/content/browser/browser/base/content/test/browser_plainTextLinks.js | Console message: [JavaScript Error: "regular expression too complex" {file: "chrome://browser/content/browser.js" line: 8021}]
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_plainTextLinks.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_plainTextLinks.js | Found a tab after previous test timed out: data:text/html,Test%20For%20Non-Hyperlinked%20url%20selection
TEST-INFO | checking window state
TEST-END | chrome://mochikit/content/browser/browser/base/content/test/browser_plainTextLinks.js | Test took 30041ms to complete

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

STR: TEST_PATH=browser/base/content/test/browser_plainTextLinks.js
EXTRA_TEST_ARGS='--debugger=gdb' make -C objdir-ff-debug/
mochitest-browser-chrome

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Forgotten OP_BRAZERO len addition.

Looks like I missed the addition of the opcode-sized OP_BRAZERO in counted-repeats... each of the 16 bracket repetitions are prefixed by an OP_BRAZERO here. The assertion was firing because the pre-computed regexp bytecode program length was too small.

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

I forgot to `hg add` the test for this... will be sure to do that before I check in. It was just the offending regexp /^(?:\s*){0,16}/ compilation crash test.

Comment 4

[Robert Sayre]

http://hg.mozilla.org/tracemonkey/rev/5bbae07fd403

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/5bbae07fd403