Closed Bug 58650 Opened 25 years ago Closed 24 years ago

no DOCTYPE tag in html source pane

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: sujay, Assigned: cmanske)

Details

(Whiteboard: FIX IN HAND)

Attachments

(3 files)

Add a read-only display of DOCTYPE tag
1.87 KB, patch
Details | Diff | Splinter Review
A better fix for case of missing doctype
2.99 KB, patch
Details | Diff | Splinter Review
Screen shot of UI as requested
19.61 KB, image/gif
Details
using 10/30 build of netscape 1) launch netscape 2) open new blank page to edit 3) insert text 4) Save (optional) 5) go into HTML source mode somehow notice we don't show the DOCTYPE tag. Should look something like this: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
The suggested doctype is a strict declaration. Editor seems to use deprecated markup heavily. Including that doctype declaration in output would be a Bad Thing. To determine which doctype to use at least these questions need to be consired: * Does Editor output deprecated markup? -- Yes. * If a transitional doctype declaration was added, would Editor's output *always* validate as HTML 4.01 Transitional? * Does Editor expect quirky layout or the CSS2 layout model (different default vertical sizing rules of boxes around images)?
the DOCTYPE I wrote up was just a sample....thats not what I was recommending. "should look something like this"
This is by design. We don't want the user to edit the doctype, since the one used is determined by the parser and not what is written in the file.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WONTFIX
ok verified in 11/8 build.
Status: RESOLVED → VERIFIED
reopen bug for further clarification Why don't we want users to be able to edit the doctype? If the user has a document with a bad doctype, they should be able to fix it. The doctype determines how the parser parses the file; the parser doesn't specify the doctype. Please clarify.
Status: VERIFIED → REOPENED
Resolution: WONTFIX → ---
We cannot allow the user to edit the DOCTYPE, as we are limited by what the parser will support, but we can show the current doctype as a read-only string above the edit source window.
Status: REOPENED → ASSIGNED
Target Milestone: --- → mozilla0.9
We cannot allow the user to edit the DOCTYPE, as we are limited by what the parser will support, but we can show the current doctype as a read-only string above the edit source window.
Whiteboard: FIX IN HAND
Charley needs to add a new diff here; the existing patch doesn't work at all if a file is opened which has no doctype. We also need to check how we handle the case where there is a doctype that is "broken" or otherwise bad.
I'd also like to see a screenshot of what the doctype field above the source pane looks like.
The 2nd fix is better but I'd prefer that we hide the doctype line ("doctype- text") if there isn't a doctype (rather than introducing a new string and taking up valuable vertical editing space).
After using this some more, I find it a little strange that the doctype doesn't scroll away when I scroll down in my html source. It feels weird to me to see the doctype in the midst of my content.
Really? Well that is certainly simpler. Simon: what do you think?
I believe it would be imposibble to have the DOCTYPE line scroll up with the document.
Checked in. If there's no DOCTYPE, you will not see the line above the editor content window for HTML source.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
So I still don't see a DOCTYPE in the html source....is this what we decided?
yes, if the document contains a doctype like: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> it appears at the top in a read-only format.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: