Closed Bug 586624 Opened 10 years ago Closed 10 years ago

support for nsIBrowserDOMWindow.OPEN_NEWWINDOW is broken

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
An exception is thrown when using the OPEN_NEWWINDOW in a call to nsIBrowserDOMWindow.openURI()

The patch makes use of the url argument to open the document in the Browser.startup() method.
Assignee: nobody → fabrice
Attachment #465212 - Flags: review?(mark.finkle)
Blocks: 584767
It would still be nice to fix this, even if it won't be used anymore by the webapps code.
Comment on attachment 465212 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser.js b/chrome/content/browser.js

>+      }
>+      else {
>+        whereURI = window.arguments[0];
>+      }

This is the new part, right? We should add a comment for why this is here

What's an easy way to test this?
(In reply to comment #2)
> Comment on attachment 465212 [details] [diff] [review]
> patch
> 
> >diff --git a/chrome/content/browser.js b/chrome/content/browser.js
> 
> >+      }
> >+      else {
> >+        whereURI = window.arguments[0];
> >+      }
> 
> This is the new part, right? We should add a comment for why this is here

yes.

> What's an easy way to test this?

Something like :  win.browserDOMWindow.openURI(uri, null, Ci.nsIBrowserDOMWindow.OPEN_NEWWINDOW, null); will test it. For instance, changing OPEN_NEWTAB for OPEN_NEWWINDOW in BrowserCLH.js
Attachment #465212 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/30e7b1c9a183
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
No longer blocks: 584767
You need to log in before you can comment on or make changes to this bug.