Closed Bug 586689 Opened 14 years ago Closed 14 years ago

investigate a better solution to timing issue in _addTabActionHandlers

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: iangilman, Unassigned)

References

Details

(Whiteboard: b5) 

From dolske's review of bug 574217: 

> >+  _addTabActionHandlers: function() {
> ...
> >+          // ToDo: When running unit tests, everything happens so quick so
> >+          // new tabs might be added after a tab is closing. Therefore, this
> >+          // hack is used. We should look for a better solution.
> 
> Eww, indeed. This might end up being ok if the need for this just ends up being
> that the event loop needs to spin once before you handle it; setTimeout(..., 0)
> can be a necessary evil in such cases.
Depends on: 574217
Whiteboard: b5
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
QA Contact: tabcandy → tabcandy
Status: NEW → RESOLVED
Closed: 14 years ago
Depends on: 586693
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.