Closed Bug 586770 Opened 10 years ago Closed 10 years ago

Missing extension points for the Account Provisioner.

Categories

(Thunderbird :: Account Manager, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird3.1 .3-fixed)

RESOLVED FIXED
Thunderbird 3.3a1
Tracking Status
thunderbird3.1 --- .3-fixed

People

(Reporter: bwinton, Assigned: bwinton)

Details

Attachments

(1 file, 1 obsolete file)

While developing the Account Provisioner, I've found a couple of places where I need a little more flexibility than what we currently have.  So here's a patch to add them in.
Comment on attachment 465360 [details] [diff] [review]
A patch to make the new account wizard a little more extensible.

Looks fine to me, but you'll need to document that it's intentionally there even though it isn't used in-tree, which means you'll have to break up that tacky documentation loop of "// @see msgOpenAccountWizard above", "// @see msgNewMailAccount below", "// @see msgOpenAccountWizard above", "// @see msgNewMailAccount below", "// @see msgOpenAccountWizard above", "// @see msgNewMailAccount below".
Attachment #465360 - Flags: review+
Assignee: nobody → bwinton
Attachment #465360 - Attachment is obsolete: true
Attachment #465377 - Flags: superreview+
Comment on attachment 465377 [details] [diff] [review]
The previous patch, with philor's suggestions.

Since the point of having the Account Provisioner as an extension is to let people try it and give us feedback before we roll it into core, it would be nice if we could get the extension points into 3.1, to let people try it.

(I don't really care which 3.1.x it gets into, though, if you didn't want to take it for 3.1.3.)

Thanks,
Blake.
Attachment #465377 - Flags: approval-thunderbird3.1.3?
Blake, can you please add some info to the list for tracking feature addons, https://wiki.mozilla.org/Thunderbird/Experiments - thanks.
Yup, done!
Comment on attachment 465377 [details] [diff] [review]
The previous patch, with philor's suggestions.

Whilst we wouldn't normally accept this type of change on a stable branch we're accepting it because: the change is such that it won't break existing extensions and only adds a small amount of code and it is very high gain for us being able to get testing of account provisioning to more users.
Attachment #465377 - Flags: approval-thunderbird3.1.3? → approval-thunderbird3.1.3+
Checked in: http://hg.mozilla.org/releases/comm-1.9.2/rev/e82ee158c3fc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.