586804 - Infinite loop on shutdown via Tester_observe

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Somehow we get into a situation where during shutdown, there's a console error message reported to nsIConsoleListeners and in browser-test.js, Tester_observe is called with its scope torn down. This triggers the "ASSERTION: XPConnect is being called on a scope without a 'Components' property!", but more importantly, the call to "new testMessage" throws a JS exception: "ReferenceError: testMessage is not defined". This JS exception is reported to the console listeners ... infinite loop.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

We need to swallow exceptions here. Nothing good can happen if we let them escape to XPCOM and be reported.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 465422 [details] [diff] [review]
fix

acceptable

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/6db5378923fb