586832 - x86_64 Mac OS X builds are targeting the wrong OS

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Josh Aas]

Our build system currently sets MACOSX_DEPLOYMENT_TARGET to 10.5 by default. This is incorrect for our 64-bit builds which target the 10.6 SDK. Bug 583318 has more info. Fixing bug 583318 is one way to fix our builds, in the mean time we should fix our mozconfigs to do the right thing.

Comment 1

[Josh Aas]

Attachment: fix v1.0

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 465487 [details] [diff] [review]
fix v1.0

Looks fine to me. I'll map those changes over to mozilla2-staging, which is our testing system and I forgot to tell you about. Will land with bug 576053 since both require 10.6 clobbers, hopefully later today.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 465487 [details] [diff] [review]
fix v1.0

As checked in (with staging):
  http://hg.mozilla.org/build/buildbot-configs/rev/c4f43c3f8cb0

Affects electrolysis, jaegermonkey, mozilla-central, places, shadow-central, tracemonkey. I've set clobbers on those branches.

We can get birch, cedar, maple, mozilla-2.0, tryserver shortly.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Other branches
  http://hg.mozilla.org/build/buildbot-configs/rev/f3c1cc7275db
with clobber set for when they next build.