Closed Bug 586832 Opened 13 years ago Closed 13 years ago

x86_64 Mac OS X builds are targeting the wrong OS

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

fix v1.0
2.71 KB, patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review 
Our build system currently sets MACOSX_DEPLOYMENT_TARGET to 10.5 by default. This is incorrect for our 64-bit builds which target the 10.6 SDK. Bug 583318 has more info. Fixing bug 583318 is one way to fix our builds, in the mean time we should fix our mozconfigs to do the right thing.
blocking2.0: --- → ?
Depends on: 583318
Attached patch fix v1.0 — — Splinter Review
Assignee: nobody → joshmoz
Attachment #465487 - Flags: review?(nrthomas)
Comment on attachment 465487 [details] [diff] [review]
fix v1.0

Looks fine to me. I'll map those changes over to mozilla2-staging, which is our testing system and I forgot to tell you about. Will land with bug 576053 since both require 10.6 clobbers, hopefully later today.
Attachment #465487 - Flags: review?(nrthomas) → review+
Comment on attachment 465487 [details] [diff] [review]
fix v1.0

As checked in (with staging):
  http://hg.mozilla.org/build/buildbot-configs/rev/c4f43c3f8cb0

Affects electrolysis, jaegermonkey, mozilla-central, places, shadow-central, tracemonkey. I've set clobbers on those branches.

We can get birch, cedar, maple, mozilla-2.0, tryserver shortly.
Attachment #465487 - Flags: checked-in+
Other branches
  http://hg.mozilla.org/build/buildbot-configs/rev/f3c1cc7275db
with clobber set for when they next build.
Status: NEW → RESOLVED
blocking2.0: ? → ---
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.