Last Comment Bug 586863 - Add invert support to cairo, or else remove #ifdef GFX_HAS_INVERT from layout
: Add invert support to cairo, or else remove #ifdef GFX_HAS_INVERT from layout
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla11
Assigned To: Ali Juma [:ajuma]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-12 19:32 PDT by Zack Weinberg (:zwol)
Modified: 2011-12-10 20:33 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Eliminate unused #ifdef GFX_HAS_INVERT blocks (7.41 KB, patch)
2011-11-25 08:29 PST, Ali Juma [:ajuma]
dbaron: review+
Details | Diff | Splinter Review

Description Zack Weinberg (:zwol) 2010-08-12 19:32:15 PDT
There are a bunch of #ifdef GFX_HAS_INVERT blocks in layout/ which are never compiled in, because the only definition of GFX_HAS_INVERT anywhere in the tree is this commented-out one in nsStyleConsts.h:

// cairo doesn't support invert
// #define GFX_HAS_INVERT

We should either make cairo support this, or strip the dead code.
Comment 1 Ali Juma [:ajuma] 2011-11-25 08:29:36 PST
Created attachment 576947 [details] [diff] [review]
Eliminate unused #ifdef GFX_HAS_INVERT blocks
Comment 2 Zack Weinberg (:zwol) 2011-11-25 08:42:39 PST
dbaron is probably a better reviewer for this stuff.
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-12-07 15:35:08 PST
Comment on attachment 576947 [details] [diff] [review]
Eliminate unused #ifdef GFX_HAS_INVERT blocks

r=dbaron
Comment 5 Ed Morley [:emorley] 2011-12-10 20:33:01 PST
https://hg.mozilla.org/mozilla-central/rev/1b0610f77f29

Note You need to log in before you can comment on or make changes to this bug.