The default bug view has changed. See this FAQ.

Add invert support to cairo, or else remove #ifdef GFX_HAS_INVERT from layout

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: zwol, Assigned: ajuma)

Tracking

Trunk
mozilla11
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
There are a bunch of #ifdef GFX_HAS_INVERT blocks in layout/ which are never compiled in, because the only definition of GFX_HAS_INVERT anywhere in the tree is this commented-out one in nsStyleConsts.h:

// cairo doesn't support invert
// #define GFX_HAS_INVERT

We should either make cairo support this, or strip the dead code.
(Assignee)

Comment 1

5 years ago
Created attachment 576947 [details] [diff] [review]
Eliminate unused #ifdef GFX_HAS_INVERT blocks
Assignee: nobody → ajuma
Status: NEW → ASSIGNED
Attachment #576947 - Flags: review?(joe)
(Reporter)

Comment 2

5 years ago
dbaron is probably a better reviewer for this stuff.
(Assignee)

Updated

5 years ago
Attachment #576947 - Flags: review?(joe) → review?(dbaron)
Comment on attachment 576947 [details] [diff] [review]
Eliminate unused #ifdef GFX_HAS_INVERT blocks

r=dbaron
Attachment #576947 - Flags: review?(dbaron) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b0610f77f29
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/1b0610f77f29
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.