Closed Bug 586863 Opened 14 years ago Closed 12 years ago

Add invert support to cairo, or else remove #ifdef GFX_HAS_INVERT from layout

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: zwol, Assigned: ajuma)

References

Details

Attachments

(1 file)

Eliminate unused #ifdef GFX_HAS_INVERT blocks
7.41 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
There are a bunch of #ifdef GFX_HAS_INVERT blocks in layout/ which are never compiled in, because the only definition of GFX_HAS_INVERT anywhere in the tree is this commented-out one in nsStyleConsts.h:

// cairo doesn't support invert
// #define GFX_HAS_INVERT

We should either make cairo support this, or strip the dead code.
Assignee: nobody → ajuma
Status: NEW → ASSIGNED

        Attachment #576947 -
        Flags: review?(joe)

    
    

    
  
dbaron is probably a better reviewer for this stuff.

    
  

        Attachment #576947 -
        Flags: review?(joe) → review?(dbaron)

    
    

    
  
Comment on attachment 576947 [details] [diff] [review]
Eliminate unused #ifdef GFX_HAS_INVERT blocks

r=dbaron

        Attachment #576947 -
        Flags: review?(dbaron) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b0610f77f29
Target Milestone: --- → mozilla11

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1b0610f77f29
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
See Also:  → 335394

          You need to log in
          before you can comment on or make changes to this bug.