Closed Bug 586904 Opened 10 years ago Closed 9 years ago

Update jQuery

Categories

(Tree Management Graveyard :: TBPL, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Swatinem, Assigned: Swatinem)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
Updates jQuery to 1.4.2. My quick testing shows that everything is working well.

Markus: I think its a good idea to also update jquery-ui, you should know better which parts of that we need.
Attachment #465588 - Flags: review?(mstange)
Comment on attachment 465588 [details] [diff] [review]
patch

Yeah, we should also update jquery-ui which we use for dragging the black panel. Unfortunately I think I made a change to it... we'll just have to see what breaks.
Attachment #465588 - Flags: review?(mstange) → review+
Attached patch update jquery-ui (obsolete) — Splinter Review
(In reply to comment #1)
> Yeah, we should also update jquery-ui which we use for dragging the black
> panel. Unfortunately I think I made a change to it... we'll just have to see
> what breaks.

If thats really the only thing what it is used for then everything works fine with the update. It’s just a shame that HTML5 DnD is not useful for this usecase.
Attachment #465596 - Flags: review?(mstange)
Comment on attachment 465596 [details] [diff] [review]
update jquery-ui

Yes, seems to work perfectly.
Attachment #465596 - Flags: review?(mstange) → review+
(In reply to comment #2)
> It’s just a shame that HTML5 DnD is not useful for this usecase.

I disagree completely. Existing mouse events are perfectly fine for this use case and HTML5 DnD has a drastically different use case.
(In reply to comment #4)
> I disagree completely. Existing mouse events are perfectly fine for this use
> case and HTML5 DnD has a drastically different use case.

Thats what I meant, the use case is completely different.

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/0c5f006dc936
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/981ac4d081c0
(bah, I messed up the first commit message :D)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This also fixes dragndrop for pending/running builds, those were dying in UI._addSuggestionLink because machineResults is empty for those. There is no add comment link in the details bar for those, and since they don’t come from tb there are no comments anyway.
Attachment #465588 - Attachment is obsolete: true
Attachment #465596 - Attachment is obsolete: true
Attachment #532448 - Flags: review?(mstange)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #532448 - Flags: review?(mstange) → review+
Please open a new bug next time. Bugs are cheap, and this update doesn't have much to do with the last one. You'll also avoid unrelated dependency bug notifications that way.
(In reply to comment #7)
> Please open a new bug next time. Bugs are cheap, and this update doesn't
> have much to do with the last one. You'll also avoid unrelated dependency
> bug notifications that way.

Will do next time.

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/51484dc0d698
Status: REOPENED → RESOLVED
Closed: 10 years ago9 years ago
Resolution: --- → FIXED
Depends on: 660184
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.