586930 - [UX] Add "Copy User Agent" functionality

Status: VERIFIED FIXED

(Input :: General, enhancement, P2)

Description

[Fred Wenzel [:wenzel]]

The "more options" per-message menu has a point "copy user agent" (currently commented out). Need to enable it and make it work.

In bug 582101 comment 4 Chris suggested a lightbox for this purpose that closes on copy, as JavaScript can't copy to the clipboard on its own.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Given bug 578055 is/was 1.7, shouldn't this be, also?

Comment 2

[Fred Wenzel [:wenzel]]

That depends. If we want to block on it, sure. If we want to deploy 1.7 ASAP, not. Also, this'll need some string changes.

Comment 3

[Aakash Desai [:aakashd]]

This is definitely a nice to have and not a blocker. Seeing as how we've already talked to folks in l10n already, I'd rather push this back.

Comment 4

[Aakash Desai [:aakashd]]

The translate comment option is kinda lonely. We should get this in for 1.8, peeps.

Comment 5

[Fred Wenzel [:wenzel]]

If we keep adding things to 1.8, we need to postpone the milestone.

Comment 6

[Aakash Desai [:aakashd]]

Good point, moving this to 2.0.

Comment 7

[Fred Wenzel [:wenzel]]

Chowse: Does this use a similar UI as the "share on twitter" thing? I wonder if we even need to allow people to copy the permalink by using a popup -- instead we could link straight to twitter with target=_blank?

This functionality here, however, certainly needs a "lightbox" closing on copy, as we can't use Flash to do it.

Comment 8

[Fred Wenzel [:wenzel]]

Assigning this to chowse for now. Will you give me some mocks, or even HTML/CSS if you have the time? This should be precisely what you've been talking about regarding a lightbox and an oncopy -> close event.

Comment 9

[Chris Howse [:chowse]]

Attachment: Copy UA Lightbox

Here's the UI for lightbox. Time permitting, I can create the HTML/CSS to go along with it.

Comment 10

[Chris Howse [:chowse]]

And here's a functioning prototype:
http://people.mozilla.com/~chowse/drop/mozilla.com/input/copy-ua/copy-ua.html

You can find all the relevant code here:
http://people.mozilla.com/~chowse/drop/mozilla.com/input/copy-ua/

Comment 11

[Fred Wenzel [:wenzel]]

Thanks, Chris. Excellent work as usual. I'll pick this up, unless someone else feels compelled to get to it before me :)

Comment 12

[Michael Kurze [:michaelk]]

Moving to 2.2 after conversing w Stephen & Aakash.

Comment 13

[Fred Wenzel [:wenzel]]

Moving all 2.2 bugs to 3.0, as their code freezes would most likely coincide.

Comment 14

[Michael Kurze [:michaelk]]

Added on master:
https://github.com/fwenzel/reporter/commit/b957c3cfea80aa0e90c2bc46f601b14934509022

We'll need a selenium test for this, as it is mostly JS.

Thanks chowse for the prototype!

Comment 15

[Fred Wenzel [:wenzel]]

Why did you add the overlay to the base template? This way it shows up on every single page that not necessarily even contains this functionality :-/

In particular, the release feedback pages now show this overlay.

Instead, you probably want to put this include into all templates where this is relevant -- there shouldn't be too many (dashboard, search, single opinion page, themes, sites are all the ones that come to mind).

Comment 16

[Fred Wenzel [:wenzel]]

Attachment: Bug screenshot

Comment 17

[Michael Kurze [:michaelk]]

Hudson is happy again, so I pushed the 2nd round for this:

Only include on dashboard pages:
https://github.com/fwenzel/reporter/commit/19faf227d0c859efc0d141ed35e5c99515cf691a

Make work with scrolling and resizing:
https://github.com/fwenzel/reporter/commit/b49b9419f9c287d12a24aa0c94abef9cd030f6bc

Comment 18

[Rebecca Billings [:rbillings]]

I'm not seeing the 'User Agent' copy anymore when viewing: http://input.stage.mozilla.com/en-US/beta/themes or http://input.stage.mozilla.com/en-US/beta/sites?q=search+page&sentiment=&version=&show_one_offs=
Shouldn't these pages have the copy, or am I misunderstanding this?

Comment 19

[Fred Wenzel [:wenzel]]

Only individual messages (not entire clusters) have user agent strings associated with them. When you click on a single theme cluster, you'll see a list of messages inside that cluster, which should have this option available.

Comment 20

[Rebecca Billings [:rbillings]]

Verified able to copy user agent from individual messages within a theme cluster

Comment 21

[David Lawrence [:dkl]]

Adding back the in-testsuite flag that was mistakenly removed.