Closed
Bug 586973
Opened 14 years ago
Closed 14 years ago
Hang with hr, floated generated content and -moz-column-count
Categories
(Core :: Layout, defect)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: martijn.martijn, Assigned: dbaron)
References
Details
(Keywords: hang, regression, testcase)
Attachments
(2 files)
|
136 bytes,
text/html
|
Details | |
|
3.73 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
See testcase, which hangs current trunk build. This regressed between 2010-08-04 and 2010-08-08, so I guess a regression from bug 563584.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → dbaron
blocking2.0: --- → final+
|
|
Assignee | |
Comment 1•14 years ago
|
||
The infinite loop is in nsColumnSetFrame::ReflowChildren, creating more next-in-flows.
|
|
Assignee | |
Comment 2•14 years ago
|
||
The problem was that for the first of the two PushFloatPastBreak calls, we weren't checking the conditions under which we're required to place something in order to avoid an infinite push loop. This factors those conditions out into a |mustPlaceFloat| variable, and checks them before the first PushFloatPastBreak call. The |pushedDown| check in the old code is equivalent to the |mustPlaceFloat = PR_FALSE| in the new code, which sets mustPlaceFloat to false when we push down.
Attachment #467315 -
Flags: review?(roc)
Attachment #467315 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5daf8744eed1
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 4•14 years ago
|
||
Verified fixed, using: https://bugzilla.mozilla.org/attachment.cgi?id=465640
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•