e10s: Check race condition of SetPriority during redirects

RESOLVED FIXED

Status

()

Core
Networking: HTTP
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mayhemer, Assigned: jdm)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(fennec2.0b2+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
After redirects are asynchronous, there seems to be a race condition during redirect processing.  See bug 536294 comment 34.

We should check this race condition is really valid and if so, fix it.
Blocks: 516730
(Assignee)

Comment 1

7 years ago
Created attachment 475605 [details] [diff] [review]
Pass SetPriority IPC messages to redirected channels.


WIP patch to trigger SetPriority on the redirected channel.
(Assignee)

Comment 2

7 years ago
Comment on attachment 475605 [details] [diff] [review]
Pass SetPriority IPC messages to redirected channels.

I'm not certain if this is the best way to do it.  It does avoid any race in the child, in that if there is a redirected channel it will be updated.  I don't know whether it's better to apply the priority to both channels or just the new one, however.
Attachment #475605 - Flags: review?(jduell.mcbugs)
(Reporter)

Comment 3

7 years ago
Comment on attachment 475605 [details] [diff] [review]
Pass SetPriority IPC messages to redirected channels.

You must check that mChannelListener->mRedirectChannel is not *this here otherwise we will have an infin. recursion.
(Assignee)

Updated

7 years ago
Attachment #475605 - Attachment is obsolete: true
Attachment #475605 - Flags: review?(jduell.mcbugs)
(Assignee)

Comment 4

7 years ago
Created attachment 476501 [details] [diff] [review]
Pass SetPriority IPC messages to redirected channels.


Good catch, thanks.
(Assignee)

Updated

7 years ago
Assignee: nobody → josh
(Assignee)

Updated

7 years ago
Attachment #476501 - Flags: review?(jduell.mcbugs)
(Assignee)

Updated

7 years ago
tracking-fennec: --- → ?

Updated

7 years ago
tracking-fennec: ? → 2.0b1+

Updated

7 years ago
tracking-fennec: 2.0b1+ → 2.0b2+
(Reporter)

Comment 5

7 years ago
Comment on attachment 476501 [details] [diff] [review]
Pass SetPriority IPC messages to redirected channels.

You should also set the priority on mChannel.  The redirect might get vetoed and the priority setting should then take effect on the original channel.  With this patch it will be lost.

r=honzab with that change.
Attachment #476501 - Flags: review?(jduell.mcbugs) → review+
(Assignee)

Comment 6

7 years ago
Created attachment 481290 [details] [diff] [review]
Pass SetPriority IPC messages to redirected channels.

Comments addressed.
(Assignee)

Updated

7 years ago
Attachment #476501 - Attachment is obsolete: true
(Assignee)

Comment 7

7 years ago
http://hg.mozilla.org/mozilla-central/rev/8e118657e810
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.