587191 - Page worker doesn't accept a URL object as content

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Hernán Rodriguez Colmeiro (:peregrino)]

If you create one page worker this way:

  pageWorker.Page({ content: require("tabs").activeTab.location});

It throws an error, about content not being an URL. The problem is that it IS a URL, just not a URL _string_.

So, as warner said on IRC: "The content option must be a string with HTML, or a URL object as returned by the 'url' module." 
If that is not the desired way, then at least the thrown error or the documentation should state that you need to pass a _string_ URL or HTML code.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 2

[Alexandre Poirot [:ochameau]]

Fixed by this commit:
https://github.com/mozilla/addon-sdk/commit/8dfbadc4624f2e7490050aaa380c13958b372ce0#packages/jetpack-core/lib/page-worker.js
Where we renamed content to contentURL and only accept URL string.
And the document now explicitely says that contentURL is a string:
https://jetpack.mozillalabs.com/sdk/1.0b3/docs/packages/addon-kit/docs/page-worker.html