587209 - Pressing F11 for full-screen it not fully hiding navbar

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

latest builds of Minefield pressing F11 does not allow full-screen.  I starts to roll-up, then leaves the Navbar exposed, with the Minefield button showing through, and the windows (min/mzx/cls) buttons in tiny style in upper right. 

regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=90b5a456b7ba&tochange=5da28c582cc7

This is going to be hard, as it has the TabCandy merge of 600+ patches.
Hopefully someone can figure which / what broke. 

Blocking b4 ?  or RelNote ?

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Attachment: Fullscreen screenshot

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

Pal-moz got a slightly different regression range:

http://hg.mozilla.org/mozilla-central/rev/874090a047df
http://hg.mozilla.org/mozilla-central/rev/906a0b05656e

maybe caused by: https://bugzilla.mozilla.org/show_bug.cgi?id=581813

Image showing change in top area besides the addition of the tab-candy button, layout looks higher:
http://img819.imageshack.us/i/ss1jr.jpg/

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

Disregard my comment #2 - wrong bug

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to comment #3)
> Disregard my comment #2 - wrong bug

never-mind - comment #2 is correct...

Comment 5

[Ed Lee :Mardak]

Seems to point to bug 581813 for sure. Getting rid of the margin makes things happy.

Comment 6

[Ed Lee :Mardak]

One potential fix would be to margin = 0 on fullscreen and restore it on exiting full screen. Or somehow fix up the animation to go all the way up. But the margin thing is a temporary fix anyway..

Comment 8

[Kevin Brosnan]

This works for me using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre

Comment 9

[Alice0775 White]

This fixed by Bug 587267 .