Closed Bug 587242 Opened 10 years ago Closed 10 years ago

Do not allow users to choose <spaces> as the collection name

Categories

(addons.mozilla.org Graveyard :: Collections, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
5.11.8

People

(Reporter: krupa.mozbugs, Assigned: davedash)

References

()

Details

(Whiteboard: [z])

steps to reproduce:
1.Go to /edit page for any collection
2.Change the collection name to just <spaces>
3.Submit the changes

expected behavior:
Submission fails with an error message

actual behavior:
traceback at https://preview.addons.mozilla.org/z/en-US/firefox/collections/kokokokokoko/%20%20/edit/
I edited your collection and added spaces for a name without any traceback, but it did save the collection with spaces, and that shouldn't happen.  -> dd for that

On the other hand, I edited the collection in the link above, and ended up on https://preview.addons.mozilla.org/z/en-US/firefox/collections/clouserw/%20%20/ which is the wrong username and wrong collection name (I had way more spaces).  I think jbalogh is fixing that already?
Assignee: nobody → dd
r?jbalogh in branch spaces
Status: NEW → ASSIGNED
http://github.com/jbalogh/zamboni/commits/9b38f66
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
I am able to reproduce the behavior listed in comment#0. Reopening...

https://preview.addons.mozilla.org/en-US/firefox/collections/lekwfkjrfh-jk/3c765eb7-ae83-401b-b78b-1cf083/
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated zamboni-lib
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
verified. If there is no collection-name,form-submit fails with an appropriate user message.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.