587242 - Do not allow users to choose <spaces> as the collection name

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Go to /edit page for any collection
2.Change the collection name to just <spaces>
3.Submit the changes

expected behavior:
Submission fails with an error message

actual behavior:
traceback at https://preview.addons.mozilla.org/z/en-US/firefox/collections/kokokokokoko/%20%20/edit/

Comment 1

[Wil Clouser [:clouserw]]

I edited your collection and added spaces for a name without any traceback, but it did save the collection with spaces, and that shouldn't happen.  -> dd for that

On the other hand, I edited the collection in the link above, and ended up on https://preview.addons.mozilla.org/z/en-US/firefox/collections/clouserw/%20%20/ which is the wrong username and wrong collection name (I had way more spaces).  I think jbalogh is fixing that already?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

r?jbalogh in branch spaces

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/9b38f66

Comment 4

[krupa raj[:krupa]]

I am able to reproduce the behavior listed in comment#0. Reopening...

https://preview.addons.mozilla.org/en-US/firefox/collections/lekwfkjrfh-jk/3c765eb7-ae83-401b-b78b-1cf083/

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Updated zamboni-lib

Comment 6

[krupa raj[:krupa]]

verified. If there is no collection-name,form-submit fails with an appropriate user message.