587262 - spell check should be enabled for textbox of tab group.

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, enhancement, P4)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre)
Gecko/20100813 Minefield/4.0b4pre ID:20100813041308
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre)
Gecko/20100813 Minefield/4.0b4pre ID:20100813041308

I can not select text by mouse drag in textbox of Tab group.
The container of the tab group moves instead.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Open TabView
3. Create tab group
4. Focus textbox on top of the Tab group
5. Input some text

Actual Results:
 spell check do not work
Expected Results:
 spell check should be enabled.

Comment 1

[Aza Raskin [:aza]]

These are two different bugs?

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

This highlights the misspelled words but the suggestion menu doesn't come up. It might need to implement the context menu for that.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #0)
> I can not select text by mouse drag in textbox of Tab group.
> The container of the tab group moves instead.

FTR, this has already been fixed a while ago.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 546119 [details] [diff] [review]
v1

Review of attachment 546119 [details] [diff] [review]:
-----------------------------------------------------------------

The patch itself looks good. Let's ask UX if we really want spell check to be enabled in Panorama's group title fields - I'm not sure about that...

Comment 5

[Alex Limi (:limi) — Firefox UX Team]

Comment on attachment 546119 [details] [diff] [review]
v1

I have no particular opinion on this. I guess it can't hurt? Famous last words :P

Comment 6

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.