Closed Bug 587317 Opened 10 years ago Closed 10 years ago

[d2d] TEST-UNEXPECTED-FAIL | mochitest/general/test_offsets.html | scrollbox scrollHeight - got 127, expected 126

Categories

(Core :: Graphics, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta4+

People

(Reporter: jrmuizel, Assigned: roc)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Rounding this value instead of flooring it seems like better behavior and works on both GDI and D2D.
Assignee: nobody → bas.schouten
Status: NEW → ASSIGNED
Correct patch this time.
Attachment #466077 - Attachment is obsolete: true
Comment on attachment 466078 [details] [diff] [review]
Rounding instead of floor scrollHeight

Roc gave his review for this on irc. You should file a follow-up bug to make this test saner by rounding correctly everywhere.
Attachment #466078 - Flags: review+
We cannot do this since it causes OS X mochitests to fail. Linux is fine though.

I tried the rounding the whole thing at the end in checkCoord but that made GDI and D2D both fail. We should probably think hard about what we're supposed to be doing here.
Attached patch fixSplinter Review
This fixes it; passes on D2D, Mac and with GDI, and I think the code is logical too.
Assignee: bas.schouten → roc
Attachment #466078 - Attachment is obsolete: true
Attachment #466192 - Flags: review?(dbaron)
Comment on attachment 466192 [details] [diff] [review]
fix

Looks like this makes everything stricter (and also slightly different) except checkCoord (is that loosening necessary?), which is good.  And if everything passes now, better.
Attachment #466192 - Flags: review?(dbaron) → review+
The checkCoord thing is safe (and needed) because scroll*, offset* and client* properties are never going to return non-integers, so if we've computed non-integer expected values we need to round those expected values the same way we round in our implementation.
Keywords: checkin-needed
Whiteboard: [needs landing]
blocking2.0: --- → beta4+
http://hg.mozilla.org/mozilla-central/rev/66415a668c19
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.