587362 - (undo delete) Undeleting messages in a thread is glitchy and crashy [@ nsImapMailFolder::PlaybackTimerCallback(nsITimer*, void*)], [@ nsImapOfflineSync::AdvanceToNextServer()] (mac)

Status: RESOLVED WORKSFORME

(Thunderbird :: Folder and Message Lists, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This has been a problem for as long as I can remember. If I delete a message in a thread (by hitting "backspace"), then undo the action with ctrl+z (or Cmd+z), one of three things randomly happens:

1) It works (unlikely)
2) The thread glitches and either displays the item wrong or visually duplicates the thread with corrupted text. Restart of TB is necessary.
3) If I undelete too quickly, I get can get a crash:

http://crash-stats.mozilla.com/report/index/79f6ac69-fecb-4704-82f6-fb6f52100814

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: glitch, before

This is the thread display before the problem occurs.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: after

This is the display after deleting, then undeleting, the middle item in the thread.

Comment 3

[David :Bienvenu]

I suspect the patch in bug 519761 should fix the crash undoing the delete. That patch is only in trunk builds at the moment.

Comment 4

[timeless]

dvander: can you trigger such a thing using a pop3 account? :)

Signature	nsImapMailFolder::PlaybackTimerCallback(nsITimer*, void*)
UUID	79f6ac69-fecb-4704-82f6-fb6f52100814
Time 	2010-08-14 12:27:02.853112
Uptime	37
Install Age	68371 seconds (19.0 hours) since version was first installed.
Product	Thunderbird
Version	3.1.2
Build ID	20100802194032
Branch	1.9.2
OS	Mac OS X
OS Version	10.6.4 10F569
CPU	x86
CPU Info	GenuineIntel family 6 model 37 stepping 5
Crash Reason	EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Crash Address	0xffffffffffecf3fe
User Comments	
Processor Notes 	
EMCheckCompatibility	False
Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 		@0xffecf3fe 	
1 	thunderbird-bin 	nsImapMailFolder::PlaybackTimerCallback 	mailnews/imap/src/nsImapMailFolder.cpp:9129
2 	libxpcom_core.dylib 	nsTimerImpl::Fire 	xpcom/threads/nsTimerImpl.cpp:427
3 	libxpcom_core.dylib 	nsTimerEvent::Run 	xpcom/threads/nsTimerImpl.cpp:519
4 	libxpcom_core.dylib 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:527
5 	libxpcom_core.dylib 	NS_ProcessPendingEvents_P 	nsThreadUtils.cpp:200

Comment 5

[David :Bienvenu]

actually, he had the component right the first time; he just put three bugs into one.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Sorry, I don't know if it's three bugs or not, just separate behaviors from the same actions :)

I don't have a POP3 account to test.

Comment 7

[David :Bienvenu]

timeless was saying this was an imap issue, and that you wouldn't be able to recreate it with pop3. And he's right about the crash, but a) that should be fixed, and b) the other issues are not imap issues.

Are you using the global inbox, or are you in the server inbox?

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

Server inbox.

Comment 9

[Wayne Mery (:wsmwk)]

only 10 crashes in  4 weeks, mostly 3.1 releases

Comment 10

[Wayne Mery (:wsmwk)]

bienvenu, is nsImapOfflineSync::AdvanceToNextServer() Mac-only crash the same issue?
bp-fb9e4b70-2c49-49e3-ab0f-129fe2100630
0	thunderbird-bin	nsImapOfflineSync::AdvanceToNextServer	 mailnews/imap/src/nsImapOfflineSync.cpp:173
1	thunderbird-bin	nsImapOfflineSync::AdvanceToNextFolder	mailnews/imap/src/nsImapOfflineSync.cpp:221
2	thunderbird-bin	nsImapOfflineSync::ProcessNextOperation	mailnews/imap/src/nsImapOfflineSync.cpp:878
3	thunderbird-bin	nsImapMailFolder::PlaybackTimerCallback	mailnews/imap/src/nsImapMailFolder.cpp:9128 

dmose crashes bp-c97e22af-0313-4171-b9f1-884b32100726 bp-2a61fe4f-c4cc-4f03-ad31-c76282100729
only other crash with an address is bp-a74dbb8b-5a64-40d2-8fc2-249642100806 (t08370mk)

only one crash this year, until v3.1 came out - now about 5 crashes per month between v3.1, v3.1.1 and v3.1.2

Comment 11

[Wayne Mery (:wsmwk)]

crashes with nsImapMailFolder::PlaybackTimerCallback on stack - 5-10 do not have bugzilla reports

1	nsImapOfflineSync::AdvanceToNextFolder()
2	nsImapOfflineSync::ProcessNextOperation()
3	nsImapMailFolder::PlaybackTimerCallback(nsITimer*, void*)
4	@0x0 | nsImapOfflineSync::ProcessNextOperation()
5	nsImapOfflineSync::nsImapOfflineSync(nsIMsgWindow*, nsIUrlListener*, nsIMsgFolder*, int) bp-af93220c-2451-4945-b41a-9af962100814
6	nsCOMPtr<nsIUnicodeDecoder>::nsCOMPtr<nsIUnicodeDecoder>(nsCOMPtr<nsIUnicodeDecoder> const&) | nsImapOfflineSync::ProcessNextOperation()
7	nsCOMPtr<nsIX509Cert>::nsCOMPtr<nsIX509Cert>(nsCOMPtr<nsIX509Cert> const&) | nsImapOfflineSync::ProcessNextOperation()
8	nsCOMPtr_base::assign_with_AddRef(nsISupports*) | nsImapOfflineSync::nsImapOfflineSync(nsIMsgWindow*, nsIUrlListener*, nsIMsgFolder*, int)  bp-5b392184-ac52-4ebe-bf74-821222100814 same as #5 above?
9	nsImapOfflineSync::AdvanceToNextServer() mentioned above in comment 10
10	thunderbird-bin@0xaf348a bp-06ad5e10-cff6-4098-abd1-e1ac62100814 Mac

Comment 12

[David :Bienvenu]

most likely, yeah, it's the same issue.

Comment 13

[Wayne Mery (:wsmwk)]

dvander, is problem gone for you with http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central-trunk/ ? Or you can wait for it to be fixed 3.1.3pre probably tuesday or wednesday.

Comment 14

[David Anderson [:dvander] - inactive, e-mail if emergency]

Symptom #3 is gone. Symptom #2 has evolved, now it re-adds the message in the wrong order. If I have three messages in a thread like:

 1. 5:00PM
   a. 6:00PM
   b. 7:00PM

If I delete 1.a, I get:

 1. 5:00PM
   a. 7:00PM
   b. 6:00PM

Comment 15

[Wayne Mery (:wsmwk)]

David, are you still not able to cause crash?

Comment 16

[David :Bienvenu]

No - is it still showing up in crash-stats?

Comment 17

[David Anderson [:dvander] - inactive, e-mail if emergency]

No, it doesn't crash anymore. Should I file a new bug on comment #14?

Comment 18

[Ludovic Hirlimann [:Usul]]

(In reply to comment #17)
> No, it doesn't crash anymore. Should I file a new bug on comment #14?

Yes please and look at https://wiki.mozilla.org/MailNews:Message_Threading#Preferences_Controlling_Threading just in case the solution lies there :D

Comment 19

[Wayne Mery (:wsmwk)]

(In reply to David Anderson [:dvander] from comment #14)
> Symptom #3 is gone. Symptom #2 has evolved, now it re-adds the message in
> the wrong order. If I have three messages in a thread like:
> 
>  1. 5:00PM
>    a. 6:00PM
>    b. 7:00PM
> 
> If I delete 1.a, I get:
> 
>  1. 5:00PM
>    a. 7:00PM
>    b. 6:00PM

I'm guessing this was filed as bug 671497