Closed Bug 587386 Opened 14 years ago Closed 14 years ago

nssCKFWHash_Create leaks rv when nssCKFWInstance_CreateMutex fails

Categories

(NSS :: Libraries, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

(Keywords: coverity, memory-leak)

Attachments

(1 file)

rv = nss_ZNEW(arena, nssCKFWHash);
...
   rv->mutex = nssCKFWInstance_CreateMutex(fwInstance, arena, pError);
   if (!rv->mutex) {
...
     return (nssCKFWHash *)NULL;
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #466070 - Flags: review?(nelson)
Comment on attachment 466070 [details] [diff] [review]
patch

Except for patches to files under /security/nss/lib/ckfw/builtins, 
patches to files under /security/nss/lib/ckfw should be reviewed by rrelyea.
Attachment #466070 - Flags: review?(nelson) → review?(rrelyea)
Comment on attachment 466070 [details] [diff] [review]
patch

r+ rrelyea
Attachment #466070 - Flags: review?(rrelyea) → review+
Checking in ckfw/hash.c;
/cvsroot/mozilla/security/nss/lib/ckfw/hash.c,v  <--  hash.c
new revision: 1.5; previous revision: 1.4
done
oops, forgot to mark it fixed.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: