nssCKFWHash_Create leaks rv when nssCKFWInstance_CreateMutex fails

RESOLVED FIXED

Status

NSS
Libraries
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity, memory-leak})

trunk
coverity, memory-leak

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.14 KB, patch
Robert Relyea
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
rv = nss_ZNEW(arena, nssCKFWHash);
...
   rv->mutex = nssCKFWInstance_CreateMutex(fwInstance, arena, pError);
   if (!rv->mutex) {
...
     return (nssCKFWHash *)NULL;
(Assignee)

Comment 1

8 years ago
Created attachment 466070 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #466070 - Flags: review?(nelson)
Comment on attachment 466070 [details] [diff] [review]
patch

Except for patches to files under /security/nss/lib/ckfw/builtins, 
patches to files under /security/nss/lib/ckfw should be reviewed by rrelyea.
Attachment #466070 - Flags: review?(nelson) → review?(rrelyea)

Comment 3

8 years ago
Comment on attachment 466070 [details] [diff] [review]
patch

r+ rrelyea
Attachment #466070 - Flags: review?(rrelyea) → review+

Comment 4

8 years ago
Checking in ckfw/hash.c;
/cvsroot/mozilla/security/nss/lib/ckfw/hash.c,v  <--  hash.c
new revision: 1.5; previous revision: 1.4
done

Comment 5

8 years ago
oops, forgot to mark it fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.