Closed
Bug 587404
Opened 15 years ago
Closed 15 years ago
nssSlot_CreateSession should return early if !readWrite
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: rrelyea)
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
4.02 KB,
patch
|
rrelyea
:
review+
|
Details | Diff | Splinter Review |
80 nssSlot_CreateSession
88 rvSession = nss_ZNEW(arenaOpt, nssSession);
92 if (readWrite) {
118 } else {
leaks rvSession:
119 return NULL;
120 }
121 }
Summary: nssSlot_CreateSession shoudl return early if !readWrite → nssSlot_CreateSession should return early if !readWrite
|
||
Comment 2•15 years ago
|
||
Comment on attachment 466128 [details] [diff] [review]
patch
review requests for patches to pk11wrap & softoken should go to rrelyea
Attachment #466128 -
Flags: review?(nelson) → review?(rrelyea)
|
Assignee | |
Comment 3•15 years ago
|
||
Comment on attachment 466128 [details] [diff] [review]
patch
nssSlot_CreateSession appears to always be called with readWrite set to true.
This code makes it clear that that is required (as well as not leaking rvSession, which is probably where timeless found the issue).
Attachment #466128 -
Flags: review?(rrelyea) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Checking in pk11wrap/dev3hack.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/dev3hack.c,v <-- dev3hack.c
new revision: 1.26; previous revision: 1.25
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•