Closed Bug 587420 Opened 14 years ago Closed 13 years ago

Intermittent failure in test_syncengine_sync.js | | test failed (with xpcshell return code: 0), followed by 2147746065 from h‌ead.js

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: jdm, Assigned: rnewman)

References

Details

(Keywords: intermittent-failure, Whiteboard: [hopefully fixed in services])

Attachments

(1 file)

Proposed patch. v1
35.76 KB, patch
philikon
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281855403.1281855857.4011.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test xpcshell on 2010/08/14 23:56:43

s: talos-r3-leopard-053
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central_leopard_test-xpcshell/build/xpcshell/tests/test_services_sync/unit/test_syncengine_sync.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | 2147746065
OS: Linux → Windows CE
Whiteboard: [orange]
OS: Windows CE → Mac OS X
Summary: Intermittent failure in test_syncengine_sync.js | | test failed (with xpcshell return code: 0), followed by 2147746065 from head.js → Intermittent failure in test_syncengine_sync.js | | test failed (with xpcshell return code: 0), followed by 2147746065 from h‌ead.js
I rejigged test_syncengine_sync.js to use add_test/run_next_test, and to make the try..finally clauses always run the test _after_ doing their cleanup.

Try build:

http://tbpl.mozilla.org/?tree=Try&rev=c0c0f886cb26

*crosses fingers*
This is the patch I threw at try. Still waiting for it to go green...
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #542100 - Flags: review?(philipp)
Comment on attachment 542100 [details] [diff] [review]
Proposed patch. v1

Woo! This made me so happy that I rebased it on top of current s-c and landed it, so that it can be part of the merge tomorrow:

https://hg.mozilla.org/services/services-central/rev/00fbd3724e94
Attachment #542100 - Flags: review?(philipp) → review+
Blocks: 648371
Whiteboard: [orange] → [orange][hopefully fixed in services]
(In reply to comment #64)

> Woo! This made me so happy that I rebased it on top of current s-c and
> landed it, so that it can be part of the merge tomorrow:

Fantastic, thanks Philipp! (This whole time zone difference is really handy, no?)
http://hg.mozilla.org/mozilla-central/rev/00fbd3724e94
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Whiteboard: [orange][hopefully fixed in services] → [hopefully fixed in services]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: